Fix breadcrumb markup and language issues from content review - #17
Open
miharp wants to merge 1 commit into
Open
Conversation
Markup: the product layout's breadcrumb closed a span with </a>, producing invalid markup on every product page. Language: brand casing in the Why OpenVox breadcrumb, OpenBolt naming in the Ansible comparison table, a stray comma on get-support, VPAT wording (sections 1194.25 and 1194.31 now correctly say the sections do not apply rather than reading as compliance failures; Javascript -> JavaScript), and open-source -> open source per the Google style guide the docs follow. The sponsor-logo empty alts on get-support were reviewed and kept: the seven linked cards already carry the company name as link text, so W3C guidance says the logos are decorative (alt=""). Adding alt text made screen readers announce each card name twice. The --ignore-empty-alt flag in test.yml is now commented to record that this is deliberate. Partially addresses OpenVoxProject#14. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Michael Harp <mike@mikeharp.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The markup and language items from #14, verified in a live browser (rendering plus accessibility tree) on top of the usual build checks.
Markup
_layouts/product.htmlclosed a<span>with</a>, shipping invalid markup on every product page. Now a matched pair; the breadcrumb renders and announces correctly.Language
Sponsor-logo alt text: reviewed and deliberately kept empty
The issue flagged the seven empty
altattributes on get-support's sponsor cards. Investigating in the browser showed the empty alts are correct: those cards are links that already carry the company name as text, so per W3C functional-images guidance the logos are decorative. Adding alt text made screen readers announce every card twice:The two featured cards (betadots, Overlook) correctly keep their alt text — their logos aren't inside links. The
--ignore-empty-altflag intest.ymlnow carries a comment documenting the rationale so it doesn't get "fixed" again.Not addressed here: the VPAT §1194.22 scoping question (whether OpenVoxDB's web dashboard counts as a web-based feature) — that's a conformance-claim decision for a maintainer, left open on #14.
Partially addresses #14.
Written with AI assistance (Claude Code); reviewed and verified by me.