Skip to content

Remove obsolete AnyAttribute compiler workaround#938

Merged
Kyle-Ye merged 1 commit into
mainfrom
bugfix/anyattribute
Jul 15, 2026
Merged

Remove obsolete AnyAttribute compiler workaround#938
Kyle-Ye merged 1 commit into
mainfrom
bugfix/anyattribute

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Jul 15, 2026

Copy link
Copy Markdown
Member

Summary

  • Remove the AnyAttribute compiler workaround and its build configuration
  • Use the native OpenAttributeGraph implementation on Linux
  • Restore the normal attribute flags, weak attribute, and rasterization paths

See details here.

Testing

  • swift build using Swift 6.2.4 on Ubuntu Jammy

Close #39

@github-actions github-actions Bot added area: graph ViewGraph, AttributeGraph, graph hosts, and graph internals. platform: Linux Linux-specific behavior or support. type: maintenance Refactor, cleanup, dependency bump, NFC, or internal maintenance. labels Jul 15, 2026
@Kyle-Ye Kyle-Ye marked this pull request as ready for review July 15, 2026 17:47
@augmentcode

augmentcode Bot commented Jul 15, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR removes the now-obsolete AnyAttribute compiler workaround (introduced for #39) and switches back to the normal AttributeGraph integration paths, including on Linux.

Changes:

  • Dropped the ANY_ATTRIBUTE_FIX environment toggle and the OPENSWIFTUI_ANY_ATTRIBUTE_FIX build define from Package.swift.
  • Deleted the workaround implementations in Sources/OpenSwiftUI/Util/AnyAttributeFix.swift and Sources/OpenSwiftUICore/Util/AnyAttributeFix.swift.
  • Removed platform-conditional importing in View_Indirect.swift, relying on the standard package import OpenAttributeGraphShims path.
  • Restored normal AttributeGraph flag/weak-attribute behavior in AttributeGraphAdditions.swift (no more unimplemented Linux path).
  • Simplified rasterization color mode / color space resolution by removing the workaround-specific branches in RasterizationOptions.swift.

Technical Notes: The change assumes the underlying compiler/toolchain no longer needs the #39 workaround and that Linux can use the native OpenAttributeGraph behavior; PR notes confirm a successful swift build on Ubuntu with Swift 6.2.4.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.93%. Comparing base (95a6131) to head (99b2401).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #938       +/-   ##
===========================================
+ Coverage   13.74%   25.93%   +12.18%     
===========================================
  Files         680      721       +41     
  Lines       44590    50700     +6110     
===========================================
+ Hits         6131    13151     +7020     
+ Misses      38459    37549      -910     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit 1c8d846 into main Jul 15, 2026
6 of 9 checks passed
@Kyle-Ye Kyle-Ye deleted the bugfix/anyattribute branch July 15, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: graph ViewGraph, AttributeGraph, graph hosts, and graph internals. platform: Linux Linux-specific behavior or support. type: maintenance Refactor, cleanup, dependency bump, NFC, or internal maintenance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot look up associated type for imported conformance

1 participant