Skip to content

Fix compatibility test import flag parsing#936

Merged
Kyle-Ye merged 1 commit into
mainfrom
codex/fix-compat-testing-import
Jul 15, 2026
Merged

Fix compatibility test import flag parsing#936
Kyle-Ye merged 1 commit into
mainfrom
codex/fix-compat-testing-import

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Jul 15, 2026

Copy link
Copy Markdown
Member

Summary

  • Centralize SwiftUI compatibility test settings in a shared [SwiftSetting] helper.
  • Pass the SwiftUI_SPI module search path as a single -I<path> compiler argument.
  • Regenerate Package.resolved for the updated manifest.

Motivation

The macOS compatibility workflow fails under Xcode 26.3 while compiling OpenSwiftUICompatibilityTests:

error: unexpected input file: .../usr/lib/swift/host/plugins/testing

SwiftPM previously emitted the custom module search option as separate -I and path arguments. With the testing plugin options added by this toolchain, the plugin directory could be misclassified as an input file.

Passing the module search path as one argument preserves the same search behavior while avoiding the argument parsing failure. The shared helper also keeps both compatibility test targets configured consistently.

@github-actions github-actions Bot added area: compatibility Compatibility, availability, legacy support, and cross-version behavior. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. area: tooling Developer tooling, package manifests, Tuist, scripts, formatting, or release tooling. platform: macOS macOS-specific behavior or support. type: build Build system, packaging, toolchain, release, or compiler support. labels Jul 15, 2026
@Kyle-Ye Kyle-Ye marked this pull request as ready for review July 15, 2026 16:43
@augmentcode

augmentcode Bot commented Jul 15, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Updates the compatibility-test targets’ SwiftPM compiler flags to pass the SwiftUI SPI module search path as a single -I<path> argument, avoiding Xcode 26.3/SwiftPM import-flag parsing failures.
Also: Centralizes the shared compatibility-test [SwiftSetting] configuration in one helper and regenerates Package.resolved accordingly.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.90%. Comparing base (e2c69fa) to head (fe170a0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
- Coverage   25.92%   25.90%   -0.02%     
==========================================
  Files         721      721              
  Lines       50788    50788              
==========================================
- Hits        13165    13159       -6     
- Misses      37623    37629       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit ee79a7c into main Jul 15, 2026
8 of 10 checks passed
@Kyle-Ye Kyle-Ye deleted the codex/fix-compat-testing-import branch July 15, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: compatibility Compatibility, availability, legacy support, and cross-version behavior. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. area: tooling Developer tooling, package manifests, Tuist, scripts, formatting, or release tooling. platform: macOS macOS-specific behavior or support. type: build Build system, packaging, toolchain, release, or compiler support.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant