Skip to content

[Bug Fix] [RB] Fix path callback Swift name#67

Merged
Kyle-Ye merged 1 commit into
mainfrom
optimize/path_warning
Jul 5, 2026
Merged

[Bug Fix] [RB] Fix path callback Swift name#67
Kyle-Ye merged 1 commit into
mainfrom
optimize/path_warning

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Jul 5, 2026

Copy link
Copy Markdown
Member

Summary

Fix the RenderBox path callback flags Swift importer name by using the valid nested type name RBPath.CallbacksFlags instead of the unsupported RBPath.Callbacks.Flags spelling.

The source header and packaged RenderBox framework header copies are updated together so consumers no longer see the invalid Swift name warning.

Root Cause

The Swift importer accepts the RBPath.Callbacks record mapping, but rejects the deeper RBPath.Callbacks.Flags record name and reports an invalid base identifier warning.

Validation

  • Typechecked the packaged RenderBox framework header through swiftc -typecheck -import-objc-header and verified RBPath.CallbacksFlags imports without the warning.
  • Built OpenSwiftUI with local dependencies enabled:
    OPENSWIFTUI_USE_LOCAL_DEPS=1 OPENRENDERBOX_USE_LOCAL_DEPS=1 OPENATTRIBUTEGRAPH_USE_LOCAL_DEPS=1 swift build --target OpenSwiftUI
  • Confirmed the local-dependency build log has no Callbacks.Flags or invalid swift_name warning matches.

@Kyle-Ye Kyle-Ye marked this pull request as ready for review July 5, 2026 18:04
@Kyle-Ye Kyle-Ye merged commit 3052c47 into main Jul 5, 2026
3 checks passed
@Kyle-Ye Kyle-Ye deleted the optimize/path_warning branch July 5, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant