[Bug Fix] [RB] Fix path callback Swift name#67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the RenderBox path callback flags Swift importer name by using the valid nested type name
RBPath.CallbacksFlagsinstead of the unsupportedRBPath.Callbacks.Flagsspelling.The source header and packaged RenderBox framework header copies are updated together so consumers no longer see the invalid Swift name warning.
Root Cause
The Swift importer accepts the
RBPath.Callbacksrecord mapping, but rejects the deeperRBPath.Callbacks.Flagsrecord name and reports an invalid base identifier warning.Validation
swiftc -typecheck -import-objc-headerand verifiedRBPath.CallbacksFlagsimports without the warning.OPENSWIFTUI_USE_LOCAL_DEPS=1 OPENRENDERBOX_USE_LOCAL_DEPS=1 OPENATTRIBUTEGRAPH_USE_LOCAL_DEPS=1 swift build --target OpenSwiftUICallbacks.Flagsor invalidswift_namewarning matches.