correctly create csj and esm build#55
Open
engbergandreas wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the build/publish configuration to produce separate CommonJS and ES module outputs and wires package.json entry points to the new dist/cjs and dist/esm layout.
Changes:
- Split TypeScript outputs into
dist/cjs(CJS + declarations) anddist/esm(ESM + declarations). - Add a dedicated
tsconfig.esm.jsonand update the build script to run both TS builds. - Update
package.jsonmain/types/exportsto point at the new per-module output directories.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tsconfig.rollup.json | Adjusts Rollup TS compilation output directory for the IIFE build. |
| tsconfig.json | Moves the default TS build output to dist/cjs (including declarations). |
| tsconfig.esm.json | Introduces a separate TS config for emitting ESM to dist/esm. |
| package.json | Updates entry points/conditional exports and build script for dual CJS+ESM publishing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
11
to
+16
| ".": { | ||
| "types": "./dist/node.d.ts", | ||
| "import": "./dist/node.js", | ||
| "require": "./dist/node.js", | ||
| "browser": "./dist/browser.js", | ||
| "default": "./dist/node.js" | ||
| "browser": "./dist/esm/browser.js", | ||
| "import": "./dist/esm/node.js", | ||
| "require": "./dist/cjs/node.js", | ||
| "types": "./dist/cjs/node.d.ts", | ||
| "default": "./dist/cjs/node.js" |
Comment on lines
3
to
7
| "compilerOptions": { | ||
| "module": "esnext", | ||
| "moduleResolution": "bundler" | ||
| "moduleResolution": "bundler", | ||
| "outDir": "./dist" | ||
| } |
Comment on lines
+3
to
+8
| "compilerOptions": { | ||
| "module": "esnext", | ||
| "moduleResolution": "bundler", | ||
| "outDir": "./dist/esm", | ||
| "declarationDir": "./dist/esm" | ||
| } |
Comment on lines
10
to
17
| "exports": { | ||
| ".": { | ||
| "types": "./dist/node.d.ts", | ||
| "import": "./dist/node.js", | ||
| "require": "./dist/node.js", | ||
| "browser": "./dist/browser.js", | ||
| "default": "./dist/node.js" | ||
| "browser": "./dist/esm/browser.js", | ||
| "import": "./dist/esm/node.js", | ||
| "require": "./dist/cjs/node.js", | ||
| "types": "./dist/cjs/node.d.ts", | ||
| "default": "./dist/cjs/node.js" | ||
| }, |
Comment on lines
+4
to
+8
| "module": "esnext", | ||
| "moduleResolution": "bundler", | ||
| "declaration": true, | ||
| "outDir": "./dist/esm", | ||
| "declarationDir": "./dist/esm" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.