Remove ControlPlots; migrate plotting to Makie + MakieControlPlots#248
Open
1-Bart-1 wants to merge 1 commit into
Open
Remove ControlPlots; migrate plotting to Makie + MakieControlPlots#2481-Bart-1 wants to merge 1 commit into
1-Bart-1 wants to merge 1 commit into
Conversation
…Plots - Delete the ControlPlots extension, examples_cp/, and the PythonCall/ Matplotlib setup (bin/install_controlplots, CI matplotlib/PyCall steps). - Collapse the plot-backend dispatch (PlotBackend/MakieBackend/ ControlPlotsBackend/set_plot_backend\!); plotting works once a Makie backend and MakieControlPlots are loaded. Drop the never-implemented plot_circulation_distribution. - VortexStepMethodMakieExt now triggers on ["Makie", "MakieControlPlots"] and renders plot_section_polars via MakieControlPlots; other plots stay native Makie. - Examples load GLMakie/CairoMakie + MakieControlPlots. - Add tests for plot_section_polars and plot_airfoils; regenerate the 1.11 and 1.12 default manifests; drop dead PyCall Aqua ignores. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
|
You write: "Everything else (geometry, distributions, polars, 3D surfaces, airfoil grids) stays native Makie — MakieControlPlots' standalone-figure API can't compose those." This is not sufficient. It must be possible to create each of the subplots of the large diagrams using MakieControlPlots.jl It might be a good idea to have a separate |
Member
Author
|
Feel free to fix this @ufechner7 , but this is the same as it was when using ControlPlots. This PR is just kept as simple as possible. |
1-Bart-1
force-pushed
the
neuralfoil
branch
2 times, most recently
from
240f6fa to
e63322b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the ControlPlots plotting backend and migrates all plotting to Makie, using MakieControlPlots where it fits.
Changes
ControlPlotsextension,examples_cp/, and thePythonCall/Matplotlib setup (bin/install_controlplots, CI matplotlib/PyCall steps,LocalPreferencesCondaPkg defaults).PlotBackend/MakieBackend/ControlPlotsBackend/set_plot_backend!). Plotting works as soon as a Makie backend andMakieControlPlotsare loaded. Also dropped the never-implementedplot_circulation_distribution.VortexStepMethodMakieExtnow triggers on["Makie", "MakieControlPlots"]and rendersplot_section_polarsviaMakieControlPlots.plot. Everything else (geometry, distributions, polars, 3D surfaces, airfoil grids) stays native Makie — MakieControlPlots' standalone-figure API can't compose those.GLMakie/CairoMakie+MakieControlPlots.:PyCallAqua ignores.Validation (headless)
plot_section_polars/plot_airfoilstests: 4/4🤖 Generated with Claude Code