fix(error-handling): route API failures through handleApiError#216
Merged
Conversation
Close several spots where API failures were swallowed or surfaced inconsistently: - dialog-publicshare-delete: add missing .catch (was an unhandled rejection) - FirmwareChannelSelector: catch channel-version fetch failures - user-selector: surface non-404 errors instead of treating every failure as 'user not found' - pwnedPasswords: throw on non-ok response instead of silently returning 0 - oauth signup create: drop dead console.log debug and let handleApiError surface validation messages; surface signup-data fetch errors - PauseToggle / MultiPauseToggle / edit-share: use handleApiError instead of hand-rolled toasts that leaked raw error.message and bypassed the 401 hook; fixes a double-toast in MultiPauseToggle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close several spots where API failures were swallowed or surfaced inconsistently: