fix(ui): add empty and not-found states to share lists and admin user page#215
Merged
Conversation
… page
The hand-rolled share list pages (outgoing/incoming/invites) rendered an
empty bordered box when there was nothing to show; add {:else} empty-state
copy. The admin user detail page showed 'Loading...' forever on a 404; add
proper loading and not-found states. Also fix an 'incomding' typo.
Member
|
shadcn has empty components for this, i would like to use them, they look good https://shadcn-svelte.com/docs/components/empty |
Replace the hand-rolled empty-state table rows and not-found paragraph with the shadcn-svelte Empty component on the share lists and admin user detail page. The share-list pages now branch on length and render an Empty block instead of an empty bordered table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hand-rolled share list pages (outgoing/incoming/invites) rendered an empty bordered box when there was nothing to show; add {:else} empty-state copy. The admin user detail page showed 'Loading...' forever on a 404; add proper loading and not-found states. Also fix an 'incomding' typo.