feat(registrant_gis): show latitude/longitude inputs on registrant form (#1143)#324
Open
emjay0921 wants to merge 1 commit into
Open
feat(registrant_gis): show latitude/longitude inputs on registrant form (#1143)#324emjay0921 wants to merge 1 commit into
emjay0921 wants to merge 1 commit into
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 19.0 #324 +/- ##
==========================================
- Coverage 74.28% 68.26% -6.02%
==========================================
Files 372 123 -249
Lines 25385 12415 -12970
==========================================
- Hits 18857 8475 -10382
+ Misses 6528 3940 -2588
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
On the registry group/individual form, GPS Coordinates only render as the MapTiler map widget. Without MapTiler configured you cannot set coordinates by clicking the map, so the values are effectively un-enterable when creating a group via the registry (OP#1143). Only Excel import (via headers) could set them.
How was the change implemented?
gis_latitude/gis_longitude) onres.partner, kept in sync with the existingcoordinatespoint:coordinates(x = longitude, y = latitude),coordinatesheader).New unit tests
test_lat_long_computed_from_coordinates— settingcoordinatespopulates the lat/long inputs.test_coordinates_built_from_lat_long— typing lat/long rebuilds thecoordinatespoint (x=lon, y=lat).test_lat_long_empty_when_no_coordinates— no point ⇒ inputs read 0.Unit tests executed by the author
spp_registrant_gissuite: 0 failed, 0 error(s) of 7 tests (fresh DB,--stop-after-init).How to test manually
8.5, Longitude124.75, save → the map marker moves to that point.Related links
https://projects.acn.fr/work_packages/1143