Security: cap client onStatus AMF keys and recv_buffer staging#104
Draft
cursor[bot] wants to merge 1 commit into
Draft
Security: cap client onStatus AMF keys and recv_buffer staging#104cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
- Cap read_onstatus object keys at MAX_OBJECT_KEYS (256), matching read_connect and skip_value limits elsewhere in the AMF layer. - Apply the same 8 MiB recv_buffer staging cap used on the server to Client::poll and recv_message so a malicious server cannot retain up to 64 MiB of incomplete wire data per connection. Co-authored-by: Alexander Wagner <info@alexanderwagnerdev.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harden client onStatus parsing and recv_buffer staging cap
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.