fix: complete TrainerRank model runtime integration#763
Merged
Conversation
Base automatically changed from
austin/e2e_pipeline_rl_on_pr_739_unify_shared_prefix
to
main
July 16, 2026 20:07
bradhilton
force-pushed
the
fix/trainer-rank-pr758-followup
branch
from
July 16, 2026 20:35
c3be588 to
6e4254d
Compare
bradhilton
force-pushed
the
fix/trainer-rank-pr758-followup
branch
from
July 16, 2026 22:14
edc2a3c to
9bfe4ef
Compare
bradhilton
marked this pull request as ready for review
July 16, 2026 23:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the
TrainerRankintegration with the model-runtime behavior added by #758.DP=1withCP=EP=world_size.Validation
uv run --no-sync prek run --all-filesuv run --no-sync python dev/trainer_rank_fast_check.py -q(75 passed, 4 skipped)mean_abs_pct=0.00155049, head-backwardmean_abs_pct=0.0CP=1/EP=4/DP=4unequal-tail case raises the documented error on all four ranks before model collectivesQwen/Qwen3.5-35B-A3B,CP=4/EP=4/DP=1, unequal dynamic slots, retained graphs, backward, and optimizer stepNo files under
src/art/megatron/**are changed.