orchestrator: Test the at-rest guarantee end to end - #421
Open
chrysh wants to merge 2 commits into
Open
Conversation
chrysh
changed the title
chrysh
marked this pull request as ready for review
August 19, 2026 19:37
chrysh
force-pushed
the
add-shell-reset
branch
2 times, most recently
from
August 20, 2026 09:30
b1d3c80 to
c180502
Compare
The reset wiring itself landed with the platform driver (BootControl composed into BoardCapabilities, assert_reset/release_reset delegating to it), so what remains here are the end-to-end proofs: a component is still held in reset while its image is verified and the line is released only on the passing verdict, and a dead reset line fails closed with the component left quiesced. BootControl is re-exported from the driver crate so board crates need only one import. Assisted-by: Claude:claude-fable-5 Signed-off-by: Christina Quast <christina.quast@9elements.com>
chrysh
force-pushed
the
add-shell-reset
branch
from
August 21, 2026 12:38
c180502 to
b4c97c2
Compare
leongross
requested changes
Aug 21, 2026
| } | ||
|
|
||
| impl Verifier for LineWatchingVerifier { | ||
| type Error = VerifierBroken; |
Member
There was a problem hiding this comment.
Must have slipped in the past review, please rename the VerifierBroken error struct to VerifierError.
Signed-off-by: Christina Quast <christina.quast@9elements.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the platform driver (#418) has merged with the reset wiring already composed in (
BootControlinBoardCapabilities,assert_reset/release_resetdelegating to it), this PR is reduced to what 418 did not carry: the end-to-end proofs of the at-rest guarantee.release_follows_verification: the component is still held in reset while its image is verified (observed from inside the verification window) and the line is released only on the passing verdict.failed_release_fails_closed: a dead reset line is a failed actuation, not a verdict — the SM latches Locked and the component never leaves reset.BootControlis re-exported from the driver crate so board crates need only one import.Part of 9elements#4.