Add Windows ARM64 wheels - #2086
Draft
ssss141414 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windows-11-armrunnerARM64processor name and enable the MSVC AArch64 NEON pathDependency
This is currently stacked on google/ruy#377. That draft dependency disables Ruy's unsupported cpuinfo integration on Windows ARM64; without it, the final link fails with an unresolved
cpuinfo_isasymbol. This PR should remain draft until the Ruy change is accepted and the submodule is repinned to its merged commit.Ruy context shutdown
A multithreaded float Ruy workload exposed a Windows TLS teardown deadlock when a replica worker exited: all inner Ruy worker functions returned, but their
std::thread::join()remained blocked while the outer worker was destroying its thread-local Ruy context. The context is now explicitly destroyed inReplicaWorker::finalize()viadestroy_context(Device::CPU), before the outer worker enters TLS cleanup. The ARM64 workflow recreates and destroys the context three times under a two-minute timeout to guard this path.Validation
Validated on native Windows ARM64 with CPython 3.13.15, Visual Studio 2022 17.14, MSVC 19.44, and Windows SDK 10.0.26100.0:
cp313-cp313-win_arm64_ext.cp313-win_arm64.pydandctranslate2.dll: PE machineAA64VCOMP140.DLLis supplied by the documented Visual C++ Redistributable