Skip to content

fix(devices): mark Pulsar X3 Medium test-needed until XS-1 driver lands #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snekxs merged 1 commit into from
Aug 16, 2026
Merged

fix(devices): mark Pulsar X3 Medium test-needed until XS-1 driver lands #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/supported-mice.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,11 @@ test("supported / PR / quickwin claims require a registered driver brand", () =>
});

// Every product id the protocol pins, so a `pids` entry that no driver knows
// about (renamed, removed, or a typo) is caught.
// about (renamed, removed, or a typo) is caught. Only rows that actually claim
// driver coverage are validated: a "test needed"/"driver needed" row pins
// aspirational PIDs that will only exist once the driver lands upstream, so it
// is exempt. The moment the protocol pins those PIDs, the row is flipped to
// "supported" and this check proves the PIDs are real.
const PID_UNIVERSE = new Set<number>([
...WLMOUSE_PRODUCTS.keys(),
...LAMZU_PRODUCTS.keys(),
Expand Down Expand Up @@ -99,9 +103,9 @@ const PID_UNIVERSE = new Set<number>([
// Finalmouse ULX dongle (drivers/finalmouse/hid.ts).
0x0100,
]);
test("every pinned PID exists in the protocol registry", () => {
test("every pinned PID on a coverage claim exists in the protocol registry", () => {
const withPids: Array<Mouse & { pids: readonly number[] }> = MICE.filter(
(m): m is Mouse & { pids: readonly number[] } => m.pids !== undefined,
(m): m is Mouse & { pids: readonly number[] } => m.pids !== undefined && (m.status === "supported" || m.status === "quickwin"),
);
assert.ok(withPids.length > 0, "no pinned PIDs to validate");
for (const m of withPids) {
Expand Down
5 changes: 3 additions & 2 deletions src/supported-mice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,9 @@ export const MICE: Mouse[] = [
note: "Pulsar driver (VID 0x3710) — collection-based detection" },
{ brand: "Pulsar", model: "X2 V3 ES Mini", status: "supported", req: 2,
note: "Pulsar driver (VID 0x3710) — collection-based detection" },
{ brand: "Pulsar", model: "X3 Medium", status: "supported", req: 1,
note: "Pulsar driver (VID 0x3710) — collection-based detection" },
{ brand: "Pulsar", model: "X3 Medium", status: "likely", req: 1,
pids: [0x3409, 0x3410, 0x5402, 0x5403],
note: "XS-1 driver written for PIDs 0x3409/0x3410/0x5402/0x5403 — pending merge + hardware test" },
{ brand: "Pulsar", model: "X2F", status: "supported", req: 1,
note: "Pulsar driver (VID 0x3710) — collection-based detection" },

Expand Down