Enable RVV-optimized TRSM kernels for RISCV64_ZVL128B#5830
Open
Felix-Gong wants to merge 1 commit into
Open
Conversation
Use existing RVV-optimized TRSM kernel implementations instead of the
generic C versions for the RISCV64_ZVL128B target. The RVV kernels
(trsm_kernel_{LN,LT,RN,RT}_rvv_v1.c) are already present in the
repository and used by the x280 target, but were not enabled for
ZVL128B.
Note: ZVL256B is not included because the RVV TRSM kernel has
correctness issues with VLEN=256.
Signed-off-by: Felix-Gong <gongxiaofei24@iscas.ac.cn>
Felix-Gong
force-pushed
the
feature/rvv-trsm-zvl128b
branch
from
c50f0a6 to
4fb51e3
Compare
Felix-Gong
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trsm_kernel_{LN,LT,RN,RT}_rvv_v1.c) forRISCV64_ZVL128Btargetx280target, but were not enabled for ZVL128B configurationNote on ZVL256B
ZVL256B is intentionally excluded from this change. Testing revealed that the RVV TRSM kernel produces incorrect results with VLEN=256 (e.g., 3x3 lower triangular solve returns wrong values). This needs to be investigated separately.
Test plan