add debug lib to CURL to avoid 'warning LNK4098: defaultlib 'MSVCRT' …#185
add debug lib to CURL to avoid 'warning LNK4098: defaultlib 'MSVCRT' …#185cbielow wants to merge 1 commit into
Conversation
…conflicts with use of other libs
📝 WalkthroughWalkthroughAdds an AGENTS.md document specifying contrib build conventions for MSVC Debug/Release libraries, and updates curl.cmake to build and install a Debug variant of libcurl prior to the Release build, with logging and failure handling on MSVC generators. ChangesMSVC Debug Build Convention
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
AGENTS.md (1)
25-28: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueAdd a language hint to the fenced code block.
Static analysis (markdownlint MD040) flags this fence for missing a language specifier.
📝 Proposed fix
-``` +```text LINK : warning LNK4098: defaultlib 'MSVCRT' conflicts with use of other libs; use /NODEFAULTLIB:library</details> <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.In
@AGENTS.mdaround lines 25 - 28, Add a language specifier to the fenced block
in AGENTS.md so the markdownlint MD040 warning is resolved; update the fence
around the LINK warning snippet to use an appropriate hint such as text, keeping
the content unchanged and locating it by the AGENTS.md fenced example.</details> <!-- cr-comment:v1:e39d491867020cbb4a8e074c --> _Source: Linters/SAST tools_ </blockquote></details> </blockquote></details> <details> <summary>🤖 Prompt for all review comments with AI agents</summary>Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.Nitpick comments:
In@AGENTS.md:
- Around line 25-28: Add a language specifier to the fenced block in AGENTS.md
so the markdownlint MD040 warning is resolved; update the fence around the LINK
warning snippet to use an appropriate hint such as text, keeping the content
unchanged and locating it by the AGENTS.md fenced example.</details> --- <details> <summary>ℹ️ Review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: Organization UI **Review profile**: CHILL **Plan**: Pro **Run ID**: `be1c30f2-5b07-469b-aea4-61215f1130d4` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between e127deafd303960ef036903bef3f987e5b689017 and 5ca407e5f69443034996d2f51377ea062bf5d2c8. </details> <details> <summary>📒 Files selected for processing (2)</summary> * `AGENTS.md` * `libraries.cmake/curl.cmake` </details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
|
thanks! |
…conflicts with use of other libs
Summary by CodeRabbit
Documentation
Bug Fixes