fix(integrations): reject duplicate catalog IDs - #396
Conversation
ec05c14 to
c7a0965
Compare
c7a0965 to
6b6196e
Compare
|
👋 This PR needs a couple of things fixed before OpenHands can review it:
Push an update once this is addressed and this check re-runs automatically. This is an automated check - no AI was used to generate this comment. |
2 similar comments
|
👋 This PR needs a couple of things fixed before OpenHands can review it:
Push an update once this is addressed and this check re-runs automatically. This is an automated check - no AI was used to generate this comment. |
|
👋 This PR needs a couple of things fixed before OpenHands can review it:
Push an update once this is addressed and this check re-runs automatically. This is an automated check - no AI was used to generate this comment. |
6b6196e to
7d57959
Compare
|
Rebased onto current |
enyst
left a comment
There was a problem hiding this comment.
Hey @kriptoburak , thank you for the proposal!
I think at this time we are not ready to test and vouch for all third party potential integrations, and we don’t know nor use xquik, sorry. But since it has an MCP, and OpenHands supports MCP natively, users can always configure the MCP and run it, right?
7d57959 to
a7e6196
Compare
|
Thanks for the direction. I removed the Xquik catalog entry entirely and rebased onto current main. The PR now contains only the independent duplicate-integration-ID guard and its regression test; the targeted suite passes 20/20. |
|
@enyst The current head I also restored the repository's PR-template sections and the required transparent |
|
Thanks for the clear direction. Closing this integration proposal because OpenHands already supports MCP configuration natively and the project is not accepting third-party integrations it cannot test and vouch for. Keeping a dedicated Xquik extension here would not match the repository's maintenance policy. |
|
Correction: reopening because the current head is materially different from the reviewed integration proposal. |
a7e6196 to
5b40754
Compare
|
@enyst Rebased the focused catalog-integrity fix onto current
|
Why
Catalog filenames are unique, but their hand-authored
idvalues can collide. The generated JavaScript and Python lookups then become ambiguous, and the last entry silently wins.Summary
Issue Number
No linked issue. This is a focused catalog-integrity fix discovered while validating an integration contribution.
How to Test
HUMAN: No human test is claimed. Automated verification ran
npm run build:integrations,uv run pytest -q tests/test_integration_catalog_in_sync.py(20 passed), andgit diff --check.To reproduce the guard, give two temporary catalog files the same
idand runnpm run build:integrations. The command must fail, name both files, and leave the generated index untouched.Video/Screenshots
Not applicable. This changes a build-time validation error.
Notes
The rejected Xquik catalog entry is no longer in this PR. The final diff contains only the independent duplicate-ID invariant and its regression test.