Fix macos fftw#766
Open
kochebina wants to merge 150 commits into
Open
Conversation
Also, fix some comments.
Replace in-house code by std::optional. Also, removing const and & from basic type arguments in setters.
E.g. calling sstringstream constructor instead of adding the value later.
Also, update the contribution section
!Work in Progress! Add the stub of the proposed solution
!Work in progress! We can actually run some simple unit tests for GatePositroniumDecayModel
!Work in Progress! Add some overlapping functionality e.g. MiniPositroniumDecayModel to be able to test the new functionality independently. This must be cleaned up later.
Add Gate initialization
Fix typo in method name, also ordering of the code etc.
Warning this is Work in Progress commit. Some part of code must be still improved
It contains a raw pointer to fDecayChannel which it does not own.
It is meant to replace the GatePositroniumDecayModel later. It uses cleaned up GatePositronium class.
Also, add a dedicated command to set the probabilites of electron captures from macro
If, no prompt emission and electron capture happens, then we repeat the sampling of the channel.
It was reversed.
…int>(fractions.size()) - 1; This -1 could lead to undefined behaviour, since it was used as a index.
Also, remove relevant tests and fix method signatures.
docs: add PositroniumSource user documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.