Use prlimit#1462
Closed
josephjclark wants to merge 5 commits into
Closed
Conversation
Collaborator
Author
|
Fantastic. Wasted a whole day on getting this ready and it turns out it's just not going to work. This won't help us. The address space limit we set has to be siginificantly larger than the space required by a run. I'll post more detai in #1370. tl;dr: If I set AS to 1gb using rlimit, thenthe node process won't even run. We need to let it allocate way more memory (the original PR uses 10x the limit). That means kubernetes will kill the pod way before the rlimit kicks in. |
But turns out this completely won't work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
Implementation Details
Spun out of #1370
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy