ucsi/v1_2/lpm: Introduce GET_PD_MESSAGE command#72
Open
RobertZ2011 wants to merge 2 commits into
Open
Conversation
f267adb to
653fcef
Compare
GET_PD_MESSAGE command
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new ucsi::v1_2 module (feature-gated behind ucsi-v1_2) and extends the UCSI v1.2 LPM command set with the GET_PD_MESSAGE command, including encode/decode plumbing and response support.
Changes:
- Move UCSI core types into
src/ucsi/v1_2/and gate them behind the newucsi-v1_2Cargo feature. - Add
GET_PD_MESSAGEcommand support inucsi::v1_2::lpm(args, response data, command routing, tests). - Add v1.2
CCItypes and addSET_POWER_LEVELcommand argument types.
Reviewed changes
Copilot reviewed 25 out of 27 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Adds the ucsi-v1_2 feature flag. |
| src/ucsi/mod.rs | Replaces previous UCSI contents with a feature-gated v1_2 module export. |
| src/ucsi/v1_2/mod.rs | New v1.2 UCSI root module (command types, headers, command/response encoding/decoding). |
| src/ucsi/v1_2/cci.rs | New v1.2 CCI bitfield wrapper types. |
| src/ucsi/v1_2/lpm/mod.rs | Wires GET_PD_MESSAGE into LPM command/response enums, encode/decode, and tests. |
| src/ucsi/v1_2/lpm/get_pd_message.rs | New command definitions for GET_PD_MESSAGE (args + response data + tests). |
| src/ucsi/v1_2/lpm/set_power_level.rs | New command definitions for SET_POWER_LEVEL (args + tests). |
| src/ucsi/v1_2/lpm/*.rs | Updates imports to reference crate::ucsi::v1_2::* types. |
| src/ucsi/v1_2/ppm/*.rs | Updates imports to reference crate::ucsi::v1_2::* types. |
| src/ucsi/v1_2/ppm/state_machine.rs | Updates UCSI module imports to use the v1.2 namespace. |
55d78b5 to
908db6a
Compare
This is an optional command that was missed in the initial implementation. Add it.
908db6a to
1f6f3ba
Compare
kurtjd
previously approved these changes
Jun 26, 2026
tullom
previously approved these changes
Jun 27, 2026
jerrysxie
previously approved these changes
Jun 27, 2026
a269f73
kurtjd
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an optional command that was skipped in the initial implementation.