Fix #83: Add extension handling to TerminalReport.generate_to_file#154
Open
fazalpsinfo-cmyk wants to merge 1 commit into
Open
Fix #83: Add extension handling to TerminalReport.generate_to_file#154fazalpsinfo-cmyk wants to merge 1 commit into
fazalpsinfo-cmyk wants to merge 1 commit into
Conversation
Contributor
|
This branch has conflicts that must be resolved |
Contributor
This branch has conflicts that must be resolved |
Contributor
|
Thanks for the PR! It currently has merge conflicts with the main branch. Please resolve the conflicts, push the updated changes, and I'll review it again. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #83 -
TerminalReport.generate_to_file()did no extension handling or default filename appending, unlike every other report generator (HTMLReport,MarkdownReport,JSONReport,ComparisonReport) which all check the output path and either append a default filename or replace the extension.Changes
HTMLReport:report.txt.txt) → replace with.txt.txt→ use as-isRelated
Fixes #83
Support open-source contributions: https://buymeacoffee.com/muhamedfazalps