fix: bind Teach corrections to halted runs - #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
openadapt-flow teachthrough the required--fixargumentRoot cause
The Teach screen recorded a correction, but it discarded the stop result. The dispatcher then called
FlowBridge.teachwithout a fix artifact. The bridge made--fixoptional even though the Flow CLI requires it. Unit fakes accepted the incomplete method call, so the UI could report a Teach attempt that the real Flow CLI could not execute.User impact
An operator can now record the corrective action, stop the recording, and submit it. Desktop binds the artifact to the current halted run and sends the exact artifact to Flow. If a newer run exists, Desktop refuses the old correction instead of teaching against stale state.
Validation
860 passed, 6 skippedin the complete Python suitenpm run build70 passedin the frontend suiteteach ... --fix ...command and stale-run refusal