Stable hash for determining if input specification changed - #24645
Open
manuelbl wants to merge 2 commits into
Open
Stable hash for determining if input specification changed#24645manuelbl wants to merge 2 commits into
manuelbl wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24644
For the Maven plugin to reliably detect if the input specification has changed, the fully parsed specification is written to a buffer (as JSON) and the hash is computed from the result.
Before, the hash was computed by calling
toString()on the parsed specification, which is not stable for all possible elements of a specification. In particular, binary data provides as an example for a property of type string / format byte was not stable.(I'm not sure why one of the pom.xml files. See the second changed file in this PR. It's a side-effect of running
generate-samples.sh.)PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Stabilizes input spec change detection in the Maven plugin by hashing the JSON-serialized OpenAPI model instead of
toString(). Unparsable specs now yield a unique hash to avoid skipping generation steps.Bug Fixes
Json.mapper(), v3.1 usesJson31.mapper()).Dependencies
resttemplate-springBoot4-jackson3: setspring-web-versionto7.0.5.Written for commit a1e0eac. Summary will update on new commits.