chore: [SDK-4728] support Gradle property override#1959
Merged
Conversation
sherwinski
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Allow Android builds to disable the OneSignal location module through the persistent
onesignal.disableLocationGradle property.Details
Motivation
ONESIGNAL_DISABLE_LOCATIONworks well for shell and CI builds, but Android projects and Expo prebuild output need a file-backed option that Gradle can read on later invocations. This adds an idiomatic Gradle property fallback while keeping the existing environment variable behavior.Scope
This affects Android dependency selection only. The existing
ONESIGNAL_DISABLE_LOCATIONenvironment variable remains supported and takes precedence over the Gradle property. iOS behavior is unchanged.Testing
Unit testing
No new unit tests were added because this change is in Gradle dependency selection logic.
Manual testing
vp check && vp testexamples/demo-no-locationenv -u ONESIGNAL_DISABLE_LOCATION ./android/gradlew -p android -Ponesignal.disableLocation=true :app:dependencies --configuration debugRuntimeClasspathexcludescom.onesignal:locationcom.onesignal:OneSignalandcom.onesignal:locationAffected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor