chore: [SDK-4728] normalize no-location opt-out#1957
Merged
Conversation
…ATION env var Replace the Android gradle property (OneSignal_disableLocation) and the iOS Podfile global ($OneSignalDisableLocation) with a single ONESIGNAL_DISABLE_LOCATION environment variable read at dependency resolution time, so the same knob works for both platforms. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove leftover cruft from the demo (the unused com.demo Android package and the orphaned vine_boom.wav asset plus its dangling Xcode references), and switch the demo to the ONESIGNAL_DISABLE_LOCATION environment variable for both iOS (Podfile) and Android (run script). Co-authored-by: Cursor <cursoragent@cursor.com>
Move the no-location environment variable out of the Podfile and onto the package scripts that run CocoaPods resolution, keeping the Podfile conventional while preserving the demo's self-contained setup. Co-authored-by: Cursor <cursoragent@cursor.com>
Update the e2e workflow version resolver after the Android dependency string moved behind the oneSignalVersion variable. Co-authored-by: Cursor <cursoragent@cursor.com>
Clarify that GitHub Actions can set ONESIGNAL_DISABLE_LOCATION at the job or step level so CocoaPods and Gradle inherit it during dependency resolution and builds. Co-authored-by: Cursor <cursoragent@cursor.com>
Accept ONESIGNAL_DISABLE_LOCATION values consistently across Android and iOS by treating true case-insensitively and accepting 1. Also remove the remaining iOS demo sound asset and references after the sound resource cleanup. Co-authored-by: Cursor <cursoragent@cursor.com>
fadi-george
changed the title
Collaborator
Author
|
@claude review |
fadi-george
force-pushed
the
fadi/sdk-4728-cleanup
branch
from
0a3f7ee to
91d7cdf
Compare
sherwinski
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Normalizes the no-location opt-out environment variable parsing and cleans up remaining demo sound assets.
Details
Motivation
Follow-up for SDK-4728 after the no-location demo stack was merged. This PR keeps
ONESIGNAL_DISABLE_LOCATIONbehavior consistent across iOS and Android by acceptingtruecase-insensitively and1on both platforms.Scope
ONESIGNAL_DISABLE_LOCATIONthe same way.vine_boom.wavassets and references after the sound resource cleanup.Testing
Manual testing
ruby -c react-native-onesignal.podspectrue,TRUE,True, and1.ONESIGNAL_DISABLE_LOCATION=1resolvescore,notifications, andin-app-messageswithoutlocation.Affected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor