feat: [SDK-4728] add no-location demo app#1954
Merged
Merged
Conversation
sherwinski
approved these changes
Jun 9, 2026
sherwinski
left a comment
Contributor
There was a problem hiding this comment.
Confirmed that the error gets emitted in logcat but the app doesn't crash:
06-09 14:21:35.283 E OneSignal: OneSignal location module is not available. Add the location dependency to use OneSignal.Location.
06-09 14:21:35.283 E OneSignal: java.lang.Exception: Must include gradle module com.onesignal:Location ...
at ...MisconfiguredLocationManager.requestPermission(MisconfiguredLocationManager.kt:16)
at ...RNOneSignal.requestLocationPermission(RNOneSignal.java:332)
854e446 to
9b8b89c
Compare
fadi-george
added a commit
that referenced
this pull request
Jun 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Adds a runnable
examples/demo-no-locationapp that demonstrates push usage without the OneSignal location module.Details
Motivation
The disable-location module flags are easier to validate and document with a small runnable app that excludes location permissions and allows manual testing of push behavior.
Scope
This stacked PR adds only the demo app changes on top of the core disable-location support PR:
$OneSignalDisableLocation = trueandOneSignal_disableLocation=truein the demo native projects.Testing
Unit testing
No unit tests were added for the demo app.
Manual testing
vp run iosinexamples/demo-no-location; app built and launched successfully.vp run androidinexamples/demo-no-location; app built, installed, and launched successfully.vp exec tsc --noEmitinexamples/demo-no-location.OneSignalLocation.TEST LOCATION REQUEST.Affected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor