Skip to content

Mahitha-hotfix(teamCodes): team Codes not being displayed in search - #5432

Open
Mahitha-pasupuleti wants to merge 3 commits into
developmentfrom
Mahitha-hotflix-teamcodes
Open

Mahitha-hotfix(teamCodes): team Codes not being displayed in search#5432
Mahitha-pasupuleti wants to merge 3 commits into
developmentfrom
Mahitha-hotflix-teamcodes

Conversation

@Mahitha-pasupuleti

@Mahitha-pasupuleti Mahitha-pasupuleti commented Aug 6, 2026

Copy link
Copy Markdown

Description

Fixing teamCodes hotfix

Video Result

https://youtu.be/yDKKWGo1F5M

@netlify

netlify Bot commented Aug 6, 2026

Copy link
Copy Markdown

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit ad1ce8b
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6a81245f481912000834f83f
😎 Deploy Preview https://deploy-preview-5432--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@DeepighaJ DeepighaJ left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR locally.
The search functionality is well implemented able to search and filter out codes.
Team code updated toast appears and message displayed when code less than 5 characters

Issue:
Teams tab goes white under dark mode.
While searching the suggested codes goes out of layout. Does this comes under PR scope?

Image Image

@Mahitha-pasupuleti

Copy link
Copy Markdown
Author

Tested the PR locally. The search functionality is well implemented able to search and filter out codes. Team code updated toast appears and message displayed when code less than 5 characters

Issue: Teams tab goes white under dark mode. While searching the suggested codes goes out of layout. Does this comes under PR scope?

Image Image

Hi Deepigha,
This PR is raised for a hotfix issue, can u please check if the hotfix issue is resolved as per the given requirement. It will be very helpful.
https://www.loom.com/share/13f10b4270ee411ab9d781a4befd0ea0

@one-community

Copy link
Copy Markdown
Member

Tested the PR locally. The search functionality is well implemented able to search and filter out codes. Team code updated toast appears and message displayed when code less than 5 characters
Issue: Teams tab goes white under dark mode. While searching the suggested codes goes out of layout. Does this comes under PR scope?
Image Image

Hi Deepigha, This PR is raised for a hotfix issue, can u please check if the hotfix issue is resolved as per the given requirement. It will be very helpful. https://www.loom.com/share/13f10b4270ee411ab9d781a4befd0ea0

Please fix these out of scope things too, so I don't have to create a new action item for these little fixes.

@Mahitha-pasupuleti

Copy link
Copy Markdown
Author

Tested the PR locally. The search functionality is well implemented able to search and filter out codes. Team code updated toast appears and message displayed when code less than 5 characters
Issue: Teams tab goes white under dark mode. While searching the suggested codes goes out of layout. Does this comes under PR scope?
Image Image

Hi Deepigha, This PR is raised for a hotfix issue, can u please check if the hotfix issue is resolved as per the given requirement. It will be very helpful. https://www.loom.com/share/13f10b4270ee411ab9d781a4befd0ea0

Please fix these out of scope things too, so I don't have to create a new action item for these little fixes.

sure

@Mahitha-pasupuleti

Copy link
Copy Markdown
Author

Tested the PR locally. The search functionality is well implemented able to search and filter out codes. Team code updated toast appears and message displayed when code less than 5 characters
Issue: Teams tab goes white under dark mode. While searching the suggested codes goes out of layout. Does this comes under PR scope?
Image Image

Hi Deepigha, This PR is raised for a hotfix issue, can u please check if the hotfix issue is resolved as per the given requirement. It will be very helpful. https://www.loom.com/share/13f10b4270ee411ab9d781a4befd0ea0

Hi Deepigha,
I made the requested changes, kindly re-review the PR.

@Mahitha-pasupuleti Mahitha-pasupuleti added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Aug 12, 2026
@beblicarl
beblicarl self-requested a review August 13, 2026 13:28

@beblicarl beblicarl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the codes exists we are still getting invalid codes

Image

https://www.loom.com/share/5a40cdbf86eb4f338581de5524834b7f

@sundarmachani sundarmachani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve checked out this functionality improvement, and it’s working as expected. However, in Dark Mode, the teams tab is completely white. Also, I believe the search result alignment could be fixed. Since we’re performing a search operation here, we can ignore the toaster display of “NOT SAVED! The code must be between 5 and 7 characters long.” Other than that, the partial or fuzzy search works.

Image Image Image Image

@sonarqubecloud

Copy link
Copy Markdown

@Mahitha-pasupuleti

Copy link
Copy Markdown
Author

I’ve checked out this functionality improvement, and it’s working as expected. However, in Dark Mode, the teams tab is completely white. Also, I believe the search result alignment could be fixed. Since we’re performing a search operation here, we can ignore the toaster display of “NOT SAVED! The code must be between 5 and 7 characters long.” Other than that, the partial or fuzzy search works.

Image Image Image Image

HI, I made the changes. Please re-review. See below video for updated result.
https://youtu.be/yDKKWGo1F5M

@Mahitha-pasupuleti

Copy link
Copy Markdown
Author

Even though the codes exists we are still getting invalid codes

Image https://www.loom.com/share/5a40cdbf86eb4f338581de5524834b7f

HI, I made the changes. Please re-review. See below video for updated result.
As per given requirements only searchability of team codes in both the search bars is part of this PR. The working of edit feature is out of scope. In case of finding any new bugs, please reach out to report a new bug.
https://youtu.be/yDKKWGo1F5M

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants