Purav Finish PR #2052 Centralize permission keys for hasPermission by pixelpix13 · Pull Request #5431 · OneCommunityGlobal/HighestGoodNetworkApp

pixelpix13 · 2026-08-06T18:29:50Z

Description

Implements permission-key constants so components no longer pass raw strings into hasPermission() (PR #2052 / task: Finish PR2052 – Create constants for permission keys).

This is a frontend refactor only (takeover of Anirudh’s WIP Anirudh_permissionsMangement). There is no new UI feature. Runtime permission values are unchanged (permissions.postProject === 'postProject'), so behavior should match development when the same permissions are assigned.

Motivation: Reused hardcoded strings across many components are typo-prone and hard to maintain. Centralizing keys in permissionKeys.js (sourced from Permissions.json + legacy keys) and using RoutePermissions in Header improves consistency and maintainability going forward (per Jae/Diego notes on PR #2052).

Fixes / Implements: PR #2052 (PRIORITY LOW – Finish constants for permission keys / WIP Purav #2052)

Related PRS (if any):

Frontend-only PR — no related backend PR.
Takeover / continuation of Anirudh’s earlier WIP branch Anirudh_permissionsMangement (never merged); reimplemented on current development with flat permissions.* keys + RoutePermissions (instead of nested hand-written constants).

Main changes explained:

Create src/utils/permissionKeys.js — builds frozen permissions map from Permissions.json + LEGACY_OR_EXTRA_KEYS; also exports permissionCategories.
Update src/utils/constants.js — re-exports permissions / permissionCategories.
Update src/utils/routePermissions.js — route/nav permission lists use permissions.* constants.
Update src/utils/permissions.js — supports array-style OR checks used by RoutePermissions.
Update Header and many feature areas (User Management, Projects/WBS, Teams, Timelog, Badges, Warnings, Permissions Management, BM/CP/KI headers, Weekly Summaries Report, Job Analytics, etc.) to call hasPermission(permissions.X) / RoutePermissions.* instead of string literals.
Update leftover access checks (viewWBSpermissionsRequired, routes Blue Square Email, frontPermissions.includes(...), etc.) to use the same constants.
Synced with latest origin/development (Header / UserManagement conflicts resolved while keeping constants).

Before	After
`hasPermission('postProject')`	`hasPermission(permissions.postProject)`
Long Header OR-chains of strings	`hasPermission(RoutePermissions.userManagement)` etc.
Scattered magic strings	Central map in `permissionKeys.js`

How to test:

Check out this branch: feature/Purav-takingover-permission-constants
Run npm install (Node v20.19.4 recommended), then start locally: npm run start:local (app at http://localhost:5173)
Clear site data/cache for localhost if needed
Log in as Admin (and also retest as Volunteer). For full role CRUD / permission toggles, use an Owner account (or ask Jae to upgrade a Dev account)

Smoke (Admin / Volunteer)

App loads with no console/runtime errors from permission checks
Header nav shows expected links for that role (Reports, User Management, Projects, Teams, Badges, Permissions Management, Send Emails, Schedule Meetings, etc.)
Permissions Management page opens
Dark mode still works normally (no UI redesign in this PR — confirm existing screens look correct in dark mode)

Permission ON / OFF regression (Owner recommended)

Toggle permissions in Permissions Management → Save → hard refresh / re-login → confirm UI:

Header / nav — Reports, Weekly Summaries, User Management, Badge Management, Projects, Teams, Permissions Management, Announcements/Send Emails, Schedule Meetings, PR Dashboard, Blue Square Email Management
User Management — list / create / delete user, status/pause, time-off, set final day
Projects / WBS / Tasks — project CRUD, members, WBS, tasks
Teams — create/edit/delete, assign members
Timelog / Weekly Summaries — edit/delete entries, edit summaries
Badges / Blue Squares / Warnings
Other — LeaderBoard, SummaryBar, Job Analytics (getJobReports), Weekly Summaries bio highlight filter

Pass criteria: ON → control available and works; OFF → hidden/disabled/blocked; no white screens.

Known note to verify

Header Badge Management uses RoutePermissions.badgeManagement, which includes assignBadges (development Header OR-chain did not). Confirm whether users with only Assign Badges should see that nav item.

Screenshots or videos of changes:

pr.5431_video.mp4

Note:

No new UI/feature — reviewers should verify behavior parity with development, not look for new screens.
Full permission regression needs Owner (or postRole / putRole / deleteRole). Admin alone may not be able to add/edit/delete roles.
Dark mode: unchanged by design; still confirm no regressions on touched pages.
CSS: no new generic global class names introduced for this refactor.
Quality Gate / SonarCloud: passed on latest analysis after cleanup commits.

…le components for improved maintainability and consistency. Updated permission checks in BMHeader, BadgeDevelopmentTable, BadgeReport, JobFormBuilder, CPHeader, Header, EnhancedJobFormBuilder, and various Project components.

…stants Co-authored-by: Cursor <cursoragent@cursor.com>

…nstants. Co-authored-by: Cursor <cursoragent@cursor.com>

netlify · 2026-08-06T18:29:56Z

✅ Deploy Preview for highestgoodnetwork-dev ready!

Name	Link
🔨 Latest commit	`2999e59`
🔍 Latest deploy log	https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6a836cc51c7cf9000831117e
😎 Deploy Preview	https://deploy-preview-5431--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

…rmission vars, add sort comparator. Co-authored-by: Cursor <cursoragent@cursor.com>

Adit0717

Tested this locally on the "feature/Purav-takingover-permission-constants" branch. Verified the following routes using both Admin and Volunteer roles:

Admin role:

/projects - accessible
/usermanagement - accessible
/badgemanagement - accessible
/teams - accessible
/permissionsmanagement - accessible
/announcements - redirected to /dashboard

Volunteer role:

/projects, /usermanagement, /badgemanagement, /teams, /permissionsmanagement - all redirected to /dashboard

DeepighaJ

I see after toggle on/off the persmission management table is not updated, it is intended behavior?
Admin:

Toggle Permission

Assign badge is toggled off and assign badge is enabled and it allows to select badges and on clicking confirm it throws below error. The message should state no permission/permission toggled off something like that.

Create team is not available as its toggled off

JobAnalytic:

Volunteer:

nathanah

I think 'update:badges' is the wrong key.
I caught some redundant role checks for owner that we can clean up while we're at it.
Could reorganize the groups to be more useful, but this is fine.
Otherwise, looks good.

nathanah · 2026-08-15T11:34:20Z

+  const canUpdateBadges = hasPermission(permissions['update:badges']);
+  const canDeleteBadges = hasPermission(permissions['delete:badges']);


Suggested change

const canUpdateBadges = hasPermission(permissions['update:badges']);

const canDeleteBadges = hasPermission(permissions['delete:badges']);

const canUpdateBadges = hasPermission(permissions.updateBadges);

const canDeleteBadges = hasPermission(permissions.deleteBadges);

Should it be this?

nathanah · 2026-08-15T11:51:21Z


  const canDeleteQuestionSets = useMemo(
-    () => userRole === 'Owner' || dispatch(hasPermission('deleteFormQuestions')),
+    () => userRole === 'Owner' || dispatch(hasPermission(permissions.deleteFormQuestions)),


Suggested change

() => userRole === 'Owner' || dispatch(hasPermission(permissions.deleteFormQuestions)),

() => dispatch(hasPermission(permissions.deleteFormQuestions)),

nathanah · 2026-08-15T11:51:29Z


  const canEditQuestionSets = useMemo(
-    () => userRole === 'Owner' || dispatch(hasPermission('editFormQuestions')),
+    () => userRole === 'Owner' || dispatch(hasPermission(permissions.editFormQuestions)),


Suggested change

() => userRole === 'Owner' || dispatch(hasPermission(permissions.editFormQuestions)),

() => dispatch(hasPermission(permissions.editFormQuestions)),

nathanah · 2026-08-15T11:51:37Z


  const canCreateQuestionSets = useMemo(
-    () => userRole === 'Owner' || dispatch(hasPermission('createFormQuestions')),
+    () => userRole === 'Owner' || dispatch(hasPermission(permissions.createFormQuestions)),


Suggested change

() => userRole === 'Owner' || dispatch(hasPermission(permissions.createFormQuestions)),

() => dispatch(hasPermission(permissions.createFormQuestions)),

nathanah · 2026-08-15T11:51:48Z


  const canCreateQuestionSets = useMemo(
-    () => userRole === 'Owner' || dispatch(hasPermission('createFormQuestions')),
+    () => userRole === 'Owner' || dispatch(hasPermission(permissions.createFormQuestions)),


Suggested change

() => userRole === 'Owner' || dispatch(hasPermission(permissions.createFormQuestions)),

() => dispatch(hasPermission(permissions.createFormQuestions)),

nathanah · 2026-08-15T11:51:56Z


  const canManageForms = useMemo(
-    () => userRole === 'Owner' || dispatch(hasPermission('manageJobForms')),
+    () => userRole === 'Owner' || dispatch(hasPermission(permissions.manageJobForms)),


Suggested change

() => userRole === 'Owner' || dispatch(hasPermission(permissions.manageJobForms)),

() => dispatch(hasPermission(permissions.manageJobForms)),

nathanah · 2026-08-15T11:54:45Z

+    props.hasPermission(RoutePermissions.permissionsManagement, !isAuthUser) ||
+    props.hasPermission(RoutePermissions.userPermissionsManagement, !isAuthUser);


Suggested change

props.hasPermission(RoutePermissions.permissionsManagement, !isAuthUser) ||

props.hasPermission(RoutePermissions.userPermissionsManagement, !isAuthUser);

props.hasPermission(RoutePermissions.permissionsManagement, !isAuthUser);

…stants

…checks, simplify Header permissionsManagement access. Co-authored-by: Cursor <cursoragent@cursor.com>

pixelpix13 · 2026-08-17T20:16:16Z

@DeepighaJ can you tell me what role did you use to test?

…on-only access pattern. Co-authored-by: Cursor <cursoragent@cursor.com>

sonarqubecloud · 2026-08-17T20:21:09Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

linlin-husky

I tried to login with Volunteer and admin Role: for both roles, Route protection works as expected. Directly navigating to admin routes (/projects, /usermanagement, /badgemanagement, /teams, /permissionsmanagement) correctly redirects back to /dashboard. Also for admin role, Core management pages and header navigation load properly with the updated permission constants.

However, when I navigated to check Badge Management, when I clicked the Edit button in badge management, the page crashed.

Attaching the crash screenshot. Could you please take a look at the modal trigger and permission checks in BadgeDevelopmentTable.jsx?

pixelpix13 and others added 4 commits August 3, 2026 21:24

Merge origin/development into feature/Purav-takingover-permission-con…

69645ba

…stants Co-authored-by: Cursor <cursoragent@cursor.com>

Merge origin/development into feature/Purav-takingover-permission-con…

6abf6ee

…stants Co-authored-by: Cursor <cursoragent@cursor.com>

Replace remaining hardcoded permission strings with permissionKeys co…

3ed9e2a

…nstants. Co-authored-by: Cursor <cursoragent@cursor.com>

Fix SonarQube issues: restore Schedule Meetings nav, remove unused pe…

fddf35b

…rmission vars, add sort comparator. Co-authored-by: Cursor <cursoragent@cursor.com>

pixelpix13 changed the title ~~Finish PR #2052: Centralize permission keys via permissionKeys constants~~ Purarv-Takingover-PR #2052: Centralize permission keys via permissionKeys constants Aug 6, 2026

pixelpix13 changed the title ~~Purarv-Takingover-PR #2052: Centralize permission keys via permissionKeys constants~~ Purav-Takingover-PR #2052: Centralize permission keys via permissionKeys constants Aug 6, 2026

pixelpix13 changed the title ~~Purav-Takingover-PR #2052: Centralize permission keys via permissionKeys constants~~ Purav Finish PR #2052 Centralize permission keys for hasPermission Aug 9, 2026

one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Aug 13, 2026

Adit0717 reviewed Aug 13, 2026

View reviewed changes

DeepighaJ requested changes Aug 15, 2026

View reviewed changes

nathanah requested changes Aug 15, 2026

View reviewed changes

pixelpix13 and others added 2 commits August 17, 2026 15:07

Merge origin/development into feature/Purav-takingover-permission-con…

88894a7

…stants

Address PR review: fix badge permission keys, remove redundant Owner …

6b24e17

…checks, simplify Header permissionsManagement access. Co-authored-by: Cursor <cursoragent@cursor.com>

OneCommunityGlobal deleted a comment from Puravpatel13 Aug 17, 2026

Remove redundant Owner role check in JobFormbuilder to match permissi…

2999e59

…on-only access pattern. Co-authored-by: Cursor <cursoragent@cursor.com>

linlin-husky requested changes Aug 18, 2026

View reviewed changes

		const canUpdateBadges = hasPermission(permissions['update:badges']);
		const canDeleteBadges = hasPermission(permissions['delete:badges']);

	() => userRole === 'Owner' \|\| dispatch(hasPermission(permissions.deleteFormQuestions)),
	() => dispatch(hasPermission(permissions.deleteFormQuestions)),

		props.hasPermission(RoutePermissions.permissionsManagement, !isAuthUser) \|\|
		props.hasPermission(RoutePermissions.userPermissionsManagement, !isAuthUser);

Uh oh!

Uh oh!

Conversation

pixelpix13 commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related PRS (if any):

Main changes explained:

How to test:

Smoke (Admin / Volunteer)

Permission ON / OFF regression (Owner recommended)

Known note to verify

Screenshots or videos of changes:

Note:

Uh oh!

netlify Bot commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for highestgoodnetwork-dev ready!

Uh oh!

Adit0717 left a comment

Choose a reason for hiding this comment

Uh oh!

DeepighaJ left a comment

Choose a reason for hiding this comment

Uh oh!

nathanah left a comment

Choose a reason for hiding this comment

Uh oh!

nathanah Aug 15, 2026

Choose a reason for hiding this comment

Uh oh!

nathanah Aug 15, 2026

Choose a reason for hiding this comment

Uh oh!

nathanah Aug 15, 2026

Choose a reason for hiding this comment

Uh oh!

nathanah Aug 15, 2026

Choose a reason for hiding this comment

Uh oh!

nathanah Aug 15, 2026

Choose a reason for hiding this comment

Uh oh!

nathanah Aug 15, 2026

Choose a reason for hiding this comment

Uh oh!

nathanah Aug 15, 2026

Choose a reason for hiding this comment

Uh oh!

pixelpix13 commented Aug 17, 2026

Uh oh!

sonarqubecloud Bot commented Aug 17, 2026

Quality Gate passed

Uh oh!

linlin-husky left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pixelpix13 commented Aug 6, 2026 •

edited

Loading

netlify Bot commented Aug 6, 2026 •

edited

Loading