Handika: Create a People Report solution for when people have more than 20 tasks. - #5405
Handika: Create a People Report solution for when people have more than 20 tasks.#5405handikaharianto wants to merge 74 commits into
Conversation
…-report-solution-for-large-tasks
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…eport details page
…er in larger screen
…-report-solution-for-large-tasks
one-community
added
the
High Priority - Please Review First
There was a problem hiding this comment.
The row limiting and empty states look good, but a few things need sorting before this merges.
The PeopleReport.jsx rewrite no longer syncs isRehireable from the loaded profile, so a non-rehireable person appears rehireable. Its new catch/finally path also renders with incomplete data after a failed request instead of retaining a safe loading or error state.
In the new chart, visibleCount starts at the full task count, so the entire table paints before it is trimmed. The CSS-module conversion in PeopleTableDetails is incomplete: several table classes are still plain strings, so the updated grid, padding, and dark-row rules cannot match. The resource-count badge also references a missing module class, and the project empty state misses the zero-hours case.
On scope, package.json is unchanged but yarn.lock has 3,982 changed lines, including registry rewrites and dependency-version changes. ApplicationTimeChart/data.js also appears unrelated and unused. The description should note that PeopleReport.jsx is a class-to-hooks rewrite and include test steps for the rewritten behavior, including the rehireable state and a failed data request.
| // render every row regardless of this number. The renderer slices in half: the | ||
| // measurement effect owns the cap, the JSX owns the slice. | ||
| const tbodyRef = useRef(null); | ||
| const [visibleCount, setVisibleCount] = useState(tasks.length); |
There was a problem hiding this comment.
visibleCount starts at tasks.length, so the first paint renders every row and the effect trims it only afterwards. With a long list, the full table can flash before it snaps down, which defeats the point of this large-list change. Starting with a small count and measuring before paint would avoid that.
| // setShowAllTasks(prev => !prev); | ||
| // } | ||
|
|
||
| const hasProjectData = hoursLoggedToProjectsOnly.length > 0; |
There was a problem hiding this comment.
This only checks whether project entries exist, not whether they have logged hours. A project entry with totalTime 0 renders this section while ProjectPieChart returns no chart, so the new empty state is skipped. The selector already exposes showProjectsPieChart using totalTime > 0; could this use that value?
DeepighaJ
left a comment
DeepighaJ
left a comment
There was a problem hiding this comment.
- Tested the PR locally,
- The Time Logged to Projects/Non-tasks and Tasks with Completed hours shows data however still empty state message is displayed in the graph section below.
- Suggestion:
The infringement graph shows No plotted data, it can say No data instead of showing a blank chart.
Hi, thanks for the review. Your screenshot doesn't reflect the latest updates of this branch. Please make sure to always pull the latest changes from the branch. I've included a video of how it looks like. Also, the section below the |
…yed when it fails
…-report-solution-for-large-tasks
|
ShreyasB02
left a comment
ShreyasB02
left a comment
There was a problem hiding this comment.
Tested this PR locally using the development backend, as the corresponding backend PR has already been merged into the development branch.
What works
- Verified the data is populated correctly in the table.
- Confirmed the pie chart renders successfully with the correct data.
- Verified the chart legend matches the corresponding pie chart segment colors and remains consistent.
- Confirmed that when the selected user has no available data, the page displays an empty state as expected.
- Dark mode renders as expected.
Suggested improvements
- When there is no data available for the infringement chart, consider displaying a message such as "No data available to display" instead of rendering an empty graph.
- In light mode, the table content could use a darker text color to improve readability and contrast.
- It would also improve the user experience if hovering over the pie chart displayed a tooltip with the corresponding segment details.
Adit0717
left a comment
Adit0717
left a comment
There was a problem hiding this comment.
Tested this locally by checking out to handika/people-report-solution-for-large-tasks, Followed all the steps and tested against the checklist.
Working as expected - on both light and dark mode:
"Tasks With Completed Hours" handles a large number of completed tasks correctly.
Empty state displays correctly when there's no data for "Tasks With Completed Hours."
Empty state displays correctly when there's no data for "Time Logged to Projects/Non-tasks."
Issue found:
Clicking on the "Infringements" graph opens a popup titled "Infringement" with a "Descriptions" header, but the content area is completely empty - no data loads inside it.
linlin-husky
left a comment
linlin-husky
left a comment
There was a problem hiding this comment.
Tested the checkpoints in admin role. Most of them work fine. I found two issues that need to be corrected:
- Infringement Modal Description Issue:
When clicking on the displayed Infringements graph for a user with recorded infringement points, the modal pops up with a "Descriptions" section that contains no text at all. Showing nothing here can easily mislead users into thinking there are no infringements, even though the graph clearly shows active data points. It would be much more user-friendly to display the detailed records or at least an informative summary (e.g., "There are 3 infringement records"). Please check the attached screenshot for reference.
- Datepicker Dark Mode UI
In dark mode, when clicking the date input in theTasks contributedsection, the datepicker popover has serious visual and rendering issues. The weekday headers (Su, Mo, Tu...) are nearly invisible due to poor text contrast against the background, and the calendar content appears severely clipped/blank (only showing day '1' while other dates are cut off). Please adjust the styling, contrast, and layout so the date picker is fully visible and usable. Please check the attached screenshot for reference.
9 participants
Description
Related PRS (if any):
This frontend PR is related to the #4635 and #3670
Main changes explained:
CompletedTasksPieChart.How to test:
handika/people-report-solution-for-large-tasksnpm installandnpm run start:localto run this PR locallyTasks With Completed Hourssection properly handles large number of completed tasks.Tasks With Completed Hourssection displays an empty state when there is no data to display.Time Logged to Projects/Non-taskssection displays an empty state when there is no data to display.Tasks With Completed HoursandTime Logged to Projects/Non-tasks.Screen.Recording.2026-08-04.at.8.49.36.PM.mov
Note:
None