Trigger renovate-approve-pr.yaml on the labeled event too - #145
Merged
Conversation
on: pull_request with no types key defaults to [opened, synchronize, reopened] -- it excludes labeled. Renovate creates a PR then adds labels (autoapprove, dependencies, etc.) as a separate follow-up call. If the opened webhook fires before the label-adding call lands, the job's autoapprove-label check sees no labels, evaluates false, and skips -- permanently, since nothing retriggers the workflow afterward. Adding labeled to the trigger types means a later label-add event re-evaluates the condition with the label actually present.
cailyoung
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on: pull_requestwith notypes:key defaults to[opened, synchronize, reopened]-- it excludeslabeled. Renovate creates a PR, then adds labels (autoapprove,dependencies, etc.) as a separate follow-up call. If theopenedwebhook fires before the label-adding call lands, the autoapprove-label check sees no labels, evaluates false, and skips -- permanently, since nothing retriggers the workflow afterward.This is a race condition that can hit any repo running this automerge pattern -- confirmed on OctopusDeploy/OctopusServerBuildHealthMonitor#344.
Changes
labeled(alongside the existing defaults) toon: pull_request: types:, so a later label-add event re-evaluates the condition with the label actually present.Part of the team-builds Dependabot -> Renovate migration follow-up: DPT-3088.
🤖 Generated with Claude Code