fix(actions): guard set_query against stale parser on filetype change#513
Merged
Merged
Conversation
vim.treesitter.get_parser() may return a previously-attached parser even after a buffer's filetype has changed (e.g. nvim-notify reusing a buffer that was previously rendered as markdown). Relying on it alone causes vim.treesitter.start() to crash because it looks up the parser via the buffer's *current* filetype (e.g. "notify"), which has no parser. Add an explicit filetype→language check (via vim.treesitter.language.get_lang) before the parser lookup so non-markdown buffers (whatever their stale parser state) exit early.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vim.treesitter.get_parser() may return a previously-attached parser even after a buffer's filetype has changed (e.g. nvim-notify reusing a buffer that was previously rendered as markdown). Relying on it alone causes vim.treesitter.start() to crash because it looks up the parser via the buffer's current filetype (e.g. "notify"), which has no parser.
Add an explicit filetype→language check (via vim.treesitter.language.get_lang) before the parser lookup so non-markdown buffers (whatever their stale parser state) exit early.