[IMP] edi_core_oca: Improve result message - #306
Open
wouitmil wants to merge 2 commits into
Open
Conversation
Contributor
OCA-git-bot
added
mod:edi_core_oca
wouitmil
force-pushed
the
edi_core_oca-improve_result_message
branch
3 times, most recently
from
June 11, 2026 15:50
20b7a5b to
382f659
Compare
simahawk
reviewed
Jun 12, 2026
Ricardoalso
force-pushed
the
edi_core_oca-improve_result_message
branch
from
July 6, 2026 09:26
382f659 to
80ead6d
Compare
Contributor
|
@wouitmil |
Ricardoalso
force-pushed
the
edi_core_oca-improve_result_message
branch
from
July 6, 2026 09:28
80ead6d to
2ff6676
Compare
Author
|
@ivantodorovich this PR is ready to be merged |
ivantodorovich
approved these changes
Jul 22, 2026
ivantodorovich
left a comment
ivantodorovich
left a comment
Contributor
There was a problem hiding this comment.
Ok to you @simahawk ?
simahawk
requested changes
Jul 22, 2026
| self._check_exchange_generate(exchange_record, force=force) | ||
| output = self._exchange_generate(exchange_record, **kw) | ||
| message = None | ||
| action_result = self._ensure_action_result( |
Contributor
There was a problem hiding this comment.
each _exchange_$action should take care of returning the wrapped result.
Here you should not wrap.
Also I wouldn't pass default_message.
Just do message = result.message or exchange_record._exchange_status_message("generate_ok")
| message = exchange_record._exchange_status_message("send_ok") | ||
| message = ( | ||
| send_result.message | ||
| or send_result.output |
Contributor
There was a problem hiding this comment.
if you want the output as a message you must return it as the message
| else "output_sent" | ||
| ) | ||
| res = message | ||
| res = send_result.output or message |
|
|
||
|
|
||
| @dataclass | ||
| class EdiExchangeActionResult: |
Contributor
There was a problem hiding this comment.
Suggested change
| class EdiExchangeActionResult: | |
| class EDIExchangeActionResult: |
Contributor
|
ping @wouitmil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.