Retry transient inference proxy unavailability - #1994
Open
kalectory wants to merge 3 commits into
Open
Conversation
A transient router<->worker breakdown surfaces as httpx.RequestError (stale/dead
cached proxy URL) or RuntimeError('...no proxy URL published...') (router dropped its
worker, not yet republished). The engine/worker stays alive across these, so
_forward_with_retry now poll-retries with a re-read proxy URL (SKYRL_PROXY_RETRY_TIMEOUT_SEC
default 900s, backoff 5s) instead of failing the whole run on the first blip. Genuine
vLLM 4xx/5xx still surface. Fixes 27B PiSSA drivers dying on a recoverable router blip.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a retry loop with configurable backoff and timeout in _forward_with_retry to handle transient vLLM proxy and network errors, along with corresponding unit tests. The review feedback suggests optimizing the retry mechanism to prevent a database read storm when multiple concurrent requests attempt to force-refresh a stale proxy URL simultaneously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing
Verified 3 retry tests pass and all configured hooks pass.