Conversation
Before this change, local desired endorsements came from three privileged channels: daemon-owned adhoc membership and token join, the daemon startup self-IP path, and the debug endorsement injection RPC. Core had multiple sources of local signed state, while operators had no single durable intent set that restart and reconciliation could treat as the source of truth. This commit makes submitted endorsement intent that source of truth. The admin CLI persists one durable intent set in State, and the manager reads that set directly when reconciling local endorsements. With that path in place, the entire daemon-owned adhoc module is removed, including its gRPC service, token plumbing, membership state, CLI, proto, and state-dump surface. The debug injection RPC is removed as well, and mesh setup in tests now submits ordinary intent instead. Future demo or join UX should be rebuilt as tooling above `intermesh intent`, not as daemon state or RPC plumbing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, local desired endorsements came from three privileged channels: daemon-owned adhoc membership and token join, the daemon startup self-IP path, and the debug endorsement injection RPC. Core had multiple sources of local signed state, while operators had no single durable intent set that restart and reconciliation could treat as the source of truth.
This commit makes submitted endorsement intent that source of truth. The admin CLI persists one durable intent set in State, and the manager reads that set directly when reconciling local endorsements. With that path in place, the entire daemon-owned adhoc module is removed, including its gRPC service, token plumbing, membership state, CLI, proto, and state-dump surface. The debug injection RPC is removed as well, and mesh setup in tests now submits ordinary intent instead.
Future demo or join UX should be rebuilt as tooling above
intermesh intent, not as daemon state or RPC plumbing.