Sprint_4 - #9
Open
NeonBlood1488 wants to merge 3 commits into
Open
Conversation
| # чтобы тесты были независимыми в каждом из них создавай отдельный экземпляр класса BooksCollector() | ||
| def test_add_new_book_with_too_long_name_not_added(self): #2, тест на слишком длинное название книги | ||
| collector = BooksCollector() | ||
| collector.add_new_book('A' * 41) |
There was a problem hiding this comment.
Можно лучше: стоит проверить и другую границу имени
Comment on lines
+41
to
+43
| if book_name == 'Существующая': | ||
| assert collector.get_book_genre(book_name) == expected_genre | ||
| else: |
There was a problem hiding this comment.
Нужно исправить: использование условных блоков в теле теста лишает их атомарности. Можно попробовать, например, расширить количество параметров или их переработать дабы избежать этой ситуации. Если не получается объединить их все, то отдельные можно разместить отдельно исключив из параметризации
Owner
Author
There was a problem hiding this comment.
я сделал 2 отдельных теста (№4 и №5)
| def test_add_new_book_with_too_long_name_not_added(self): #2, тест на слишком длинное название книги | ||
| collector = BooksCollector() | ||
| collector.add_new_book('A' * 41) | ||
| assert len(collector.get_books_genre()) == 0 |
There was a problem hiding this comment.
Необходимо исправить: не хватает позитивного теста на проверку длины имени книги
Comment on lines
+27
to
+30
| if expected_added: | ||
| assert name in collector.get_books_genre() | ||
| else: | ||
| assert name not in collector.get_books_genre() |
There was a problem hiding this comment.
Стоит разделить позитивные/негативные тесты
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.