fix: set tagName on NgView for Angular 21 bootstrap compatibility#167
Closed
Copilot wants to merge 2 commits into
Closed
fix: set tagName on NgView for Angular 21 bootstrap compatibility#167Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix: set tagName on NgView for Angular 21 bootstrap compatibility
fix: set tagName on NgView for Angular 21 bootstrap compatibility
May 27, 2026
Contributor
|
This is missing files, closing in favor of: #168 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR isolates commit
17173d2e3714d8bcb23d466557d34fd627f79a07into a standalone change.It addresses Angular 21 bootstrap behavior where
locateHostElementreadsrootElement.tagName.toLowerCase(), which can throw when NativeScript root elements lack a stringtagName.Root-element compatibility guard
selectRootElementinpackages/angular/src/lib/nativescript-renderer.tsto normalize all return paths through a localensureTagName(...)helper.tagName(derived fromnodeName, selector fallback, or'view').Behavioral scope
selectRootElementbranches:Viewinput#idlookup pathrootViewOriginal prompt
This pull request was created from Copilot chat.