fix: RA2.2 README test command references missing 90-pod.yaml - #210
Conversation
Greptile SummaryThe PR updates the RA2.2 testing instructions to apply the rendered example DaemonSet and execute checks in one of its pods, but the apply command still names a file that normal generation does not emit.
Confidence Score: 4/5The PR is not yet safe to merge because its revised apply command still points to a workload filename that normal generation does not create. Normal generation emits the example DaemonSet as 90-example-daemonset-.yaml, while the README directs users to the nonexistent bare filename. Files Needing Attention: profiles/spectrum-x-ra2.2/README.md Important Files Changed
Reviews (2): Last reviewed commit: "fix: RA2.2 README test command reference..." | Re-trigger Greptile |
Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
dadc2d5 to
8ed1f8e
Compare
|
@greptile-apps Thanks for the review. I have updated the testing section to use the rendered manifest path |
|
Both changes look good:
LGTM. |
|
|
||
| ```bash | ||
| kubectl apply -f 90-pod.yaml | ||
| kubectl apply -f ./output/network-operator/90-example-daemonset.yaml |
There was a problem hiding this comment.
Generated workload filename mismatches
When a user generates the RA2.2 deployment files and follows this command, generation appends the merged group identifier to the DaemonSet filename, so the referenced bare 90-example-daemonset.yaml path does not exist and kubectl apply cannot deploy the example workload.
Knowledge Base Used: Spectrum-X addressing and topology
This PR corrects the documentation in
profiles/spectrum-x-ra2.2/README.md: RA2.2 README test command references missing 90-pod.yaml.Changes
profiles/spectrum-x-ra2.2/README.md: RA2.2 README test command references missing 90-pod.yaml.Details
bash
-kubectl apply -f 90-pod.yaml
+kubectl apply -f ./output/network-operator/90-example-daemonset.yaml