fix(nvlink): use GPU platform chassis serial when nvlink_info is unset.#3483
Merged
Conversation
This should help with auto population of nvlink_info for managed hosts that are missing that info. Signed-off-by: Roopesh Tamma <rtamma@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Summary by CodeRabbit
WalkthroughChangesChassis serial resolution
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/api-model/src/hardware_info.rs`:
- Around line 967-977: Convert first_gpu_platform_chassis_serial into a
table-driven test using the established value_scenarios!/scenarios! helpers,
covering no GPUs, a GPU with missing platform_info, blank or whitespace-only
serials, and a valid serial; assert each scenario’s expected Option result and
remove the current imperative setup/assertions.
In `@crates/nvlink-manager/src/lib.rs`:
- Around line 78-93: Normalize the GPU-platform fallback in
managed_host_chassis_serial the same way as the nvlink_info chassis_serial path:
trim the value, discard it if empty, and only then return it as the grouping
key. Preserve the existing NMX-C-first fallback order and use
HardwareInfo::first_gpu_platform_chassis_serial as the fallback source.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: b416c2f8-3ae0-4689-ac59-e07b68ab5c73
📒 Files selected for processing (2)
crates/api-model/src/hardware_info.rscrates/nvlink-manager/src/lib.rs
Signed-off-by: Roopesh Tamma <rtamma@nvidia.com>
tmcroberts97
approved these changes
Jul 14, 2026
🔍 Container Scan Summary
Per-CVE detail lives in the per-service |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help with auto population of nvlink_info for managed hosts that are missing that info.
Fall back to the first GPU platform_info chassis_serial from machine
topology when nvlink_info is missing or empty, so MNNVL-capable hosts
can still be grouped and have nvlink_info populated from NMX-C hello.
Related issues
#3481
Type of Change
Breaking Changes
Testing
Additional Notes