fix: validate trusted source hosts for SC2#118
Open
Bortlesboat wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.comin the query stringWhy
_is_trusted_source()previously searched the entire matched command text for trusted domains. That allowed an untrusted host such asmalicious.evilto be downgraded ifgithub.comappeared in the query string or another non-host part of the URL.Tests
uv run pytest tests/unit/test_patterns_new.py -k trusted_domain_in_query -quv run pytest tests/unit/test_patterns_new.py -quv run ruff check src/skillspector/nodes/analyzers/static_patterns_supply_chain.py tests/unit/test_patterns_new.pyNote: the broader non-integration suite still has unrelated Windows-only path separator failures in existing tests. The touched static pattern suite passes.
Closes #110