Skip to content

fix(proxy): normalize trailing-dot CONNECT hosts before policy evaluation#2248

Open
letv1nnn wants to merge 1 commit into
NVIDIA:mainfrom
letv1nnn:2201-normalize-trailing-dot-host
Open

fix(proxy): normalize trailing-dot CONNECT hosts before policy evaluation#2248
letv1nnn wants to merge 1 commit into
NVIDIA:mainfrom
letv1nnn:2201-normalize-trailing-dot-host

Conversation

@letv1nnn

Copy link
Copy Markdown

Summary

Fixes inconsistent handling of trailing-dot hostnames (e.g. api.example.com.) in the sandbox supervisor's CONNECT proxy. Such hosts are valid RFC 1034 FQDNs used in Kubernetes ndots:5 environments to bypass search-domain expansion, but were treated as distinct from their undotted equivalents across policy evaluation, middleware selection, and credential matching.

Related Issue

#2201

Changes

  • Strip one trailing dot from CONNECT host before policy checks, normalize_connect_host(raw_host: &str) -> &str {...}
  • DNS resolvers still get the original dotted form (preserves ndots:5 bypass)
  • Unit tests for the normalization helper

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

@copy-pr-bot

copy-pr-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@TaylorMutch

Copy link
Copy Markdown
Collaborator

/ok to test 8384df5

…tion

Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
@letv1nnn letv1nnn force-pushed the 2201-normalize-trailing-dot-host branch from 8384df5 to 1544036 Compare July 13, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants