fix(proxy): normalize trailing-dot CONNECT hosts before policy evaluation#2248
Open
letv1nnn wants to merge 1 commit into
Open
fix(proxy): normalize trailing-dot CONNECT hosts before policy evaluation#2248letv1nnn wants to merge 1 commit into
letv1nnn wants to merge 1 commit into
Conversation
Collaborator
|
/ok to test 8384df5 |
…tion Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
8384df5 to
1544036
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes inconsistent handling of trailing-dot hostnames (e.g. api.example.com.) in the sandbox supervisor's CONNECT proxy. Such hosts are valid RFC 1034 FQDNs used in Kubernetes
ndots:5environments to bypass search-domain expansion, but were treated as distinct from their undotted equivalents across policy evaluation, middleware selection, and credential matching.Related Issue
#2201
Changes
normalize_connect_host(raw_host: &str) -> &str {...}Testing
mise run pre-commitpassesChecklist