Skip to content

fix(core): preserve SSH gateway default ports#1602

Merged
TaylorMutch merged 1 commit into
mainfrom
fix-ssh-gateway-default-port/tm
May 27, 2026
Merged

fix(core): preserve SSH gateway default ports#1602
TaylorMutch merged 1 commit into
mainfrom
fix-ssh-gateway-default-port/tm

Conversation

@TaylorMutch
Copy link
Copy Markdown
Collaborator

Summary

Preserve the externally reachable default HTTP/HTTPS port when resolving the SSH gateway URL from a cluster endpoint. This prevents openshell sandbox connect from falling back to the server internal bind port when the gateway URL omits an explicit default port.

Related Issue

None.

Changes

  • Use Url::port_or_known_default() when resolving the SSH gateway cluster port.
  • Update resolver tests for default HTTPS ports and add coverage for a default HTTP endpoint.

Testing

  • cargo test -p openshell-core resolve_ssh_gateway passes
  • mise run pre-commit passes (fails in upstream rust:lint on unrelated crates/openshell-sandbox/src/process.rs:23 unused import: warn)
  • Unit tests added/updated
  • E2E tests added/updated (not applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
@TaylorMutch TaylorMutch merged commit dc1f098 into main May 27, 2026
26 checks passed
@TaylorMutch TaylorMutch deleted the fix-ssh-gateway-default-port/tm branch May 27, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants