fix(cli): preserve symlinks during sandbox upload#1595
Merged
Conversation
TaylorMutch
previously approved these changes
May 27, 2026
|
🌿 Preview your docs: https://nvidia-preview-pr-1595.docs.buildwithfern.com/openshell |
|
Label |
TaylorMutch
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve symlink entries when building sandbox upload tar archives instead of dereferencing them into their targets. This also routes single symlink uploads around git-filter canonicalization and uses symlink-aware existence checks so dangling symlinks are handled consistently.
Related Issue
Fixes #1425
Supersedes #1561
Changes
symlink_metadata-based traversal that emits symlink tar entries.git_sync_filesfor single symlink uploads so tracked, untracked, and dangling symlinks reach the archive writer.sandbox upload, create-time--upload, and legacy sync upload paths.Testing
cargo test -p openshell-cli symlinkcargo test -p openshell-clicargo fmt --all -- --checkgit diff --checkmise run pre-commitdocker-devon0.0.51-dev.5+gac6a0a02Checklist