test: stabilize ARM runner setup#433
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🧰 Additional context used📓 Path-based instructions (11).github/workflows/*.{yml,yaml}📄 CodeRabbit inference engine (.agents/skills/maintain-ci/SKILL.md)
Files:
{justfile,codecov.yml,codecov.yaml,.github/workflows/**/*.yml,.github/workflows/**/*.yaml}📄 CodeRabbit inference engine (.agents/skills/maintain-dynamic-plugins/SKILL.md)
Files:
{.github/**,.gitlab-ci.yml,.pre-commit-config.yaml,justfile,scripts/**}⚙️ CodeRabbit configuration file
Files:
**/*.rs📄 CodeRabbit inference engine (.agents/skills/prepare-pr/SKILL.md)
Files:
**/*.{rs,py}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{rs,py,js,mjs,cjs,ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{rs,py,go,js,ts,c,h}📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
**/*.{rs,go,js,ts}📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
**/*📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Files:
**/*.{rs,py,go,js,ts}📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Files:
{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}⚙️ CodeRabbit configuration file
Files:
🧠 Learnings (1)📚 Learning: 2026-05-03T04:23:07.497ZApplied to files:
🪛 zizmor (1.26.1).github/workflows/ci_rust.yml[warning] 241-241: code injection via template expansion (template-injection): may expand into attacker-controllable code (template-injection) 🔇 Additional comments (2)
WalkthroughThe changes harden musl package installation in the Rust CI workflow and replace a hardcoded sidecar publication test timeout with a shared 30-second constant. ChangesCI package installation resilience
Sidecar publication test timeout
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/merge |
#### Overview This isolates an unrelated Linux CI flake observed while validating #433. The worker cancellation contract succeeded, but its client task exceeded a two-second test deadline under a fully loaded Rust matrix. - [x] I confirm this contribution is my own work, or I have the right to submit it under this project license. - [x] I searched existing issues and open pull requests, and this does not duplicate existing work. #### Details Use one named 10-second deadline for both worker cancellation tests. The tests still fail boundedly when cancellation stalls, while allowing scheduling delays on loaded CI hosts. Production behavior is unchanged. Validation: - Repeated worker_service_cancels_unary_and_stream_invocations_by_id 30 times. - cargo clippy -p nemo-relay-worker --test worker_sdk_tests -- -D warnings - just test-rust - uv run pre-commit run --all-files #### Where should the reviewer start? Review WORKER_TEST_TIMEOUT and its two cancellation-test call sites in crates/worker/tests/worker_sdk_tests.rs. #### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to) - Relates to #433 ## Summary by CodeRabbit * **Tests** * Standardized timeout handling in cancellation-related asynchronous tests. * Preserved existing test behavior while improving consistency and reliability. Authors: - Will Killian (https://github.com/willkill07) Approvers: - Zhongxuan (Daniel) Wang (https://github.com/zhongxuanwang-nv) URL: #436
Overview
This isolates two unrelated ARM CI failures observed while validating #428: a sidecar-publication timing flake and transient Ubuntu ports package-download failures.
Details
No production runtime behavior changes.
Validation:
Where should the reviewer start?
Start with the Install musl tools step in .github/workflows/ci_rust.yml, then review the test-only timeout constant in crates/cli/tests/cli_tests.rs.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
Chores
Tests