fix(autocast): add missing guard for use_standalone_type_inference#1743
Open
agkphysics wants to merge 1 commit into
Open
fix(autocast): add missing guard for use_standalone_type_inference#1743agkphysics wants to merge 1 commit into
agkphysics wants to merge 1 commit into
Conversation
Signed-off-by: Aaron Keesing <aaron.keesing@zozo.com>
Contributor
📝 WalkthroughWalkthroughIn ChangesConditional dim_param rewrite in PrecisionConverter
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Bug fix
Adds a missing check for
use_standalone_type_inferencein AutoCast which can cause shape issues because some dims are replaces withunk.Testing
I have tested this with a model that previously failed after AutoCast conversion with the following error, but succeeds with this patch:
Before your PR is "Ready for review"
CONTRIBUTING.md: N/ASummary by CodeRabbit