Skip to content

fix: use proper image registry for stable release - #985

Open
mckornfield wants to merge 1 commit into
mainfrom
fix-image-registry-helm-chart/mck
Open

fix: use proper image registry for stable release#985
mckornfield wants to merge 1 commit into
mainfrom
fix-image-registry-helm-chart/mck

Conversation

@mckornfield

@mckornfield mckornfield commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Corrected stable release packaging to use the designated container image registry when publishing Helm charts.
    • Improved consistency between stable release images and their Helm chart configuration.

Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
@mckornfield
mckornfield requested a review from a team as a code owner July 30, 2026 04:56
@github-actions github-actions Bot added the fix label Jul 30, 2026
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ba53e109-3d89-4be5-bd84-867d111b1484

📥 Commits

Reviewing files that changed from the base of the PR and between d478469 and 52cdf5b.

📒 Files selected for processing (1)
  • .github/workflows/release.yaml

📝 Walkthrough

Walkthrough

The release workflow adds STABLE_IMAGE_REGISTRY and uses it in the stable Helm chart packaging step instead of RELEASE_HELM_REGISTRY.

Changes

Stable image registry

Layer / File(s) Summary
Helm stable registry wiring
.github/workflows/release.yaml
Adds the stable image registry workflow variable and passes it to the stage-helm packaging step.

Possibly related PRs

Suggested reviewers: crookedstorm, svvarom

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change to use a dedicated stable image registry for Helm releases.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-image-registry-helm-chart/mck

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 28219/36050 78.3% 62.7%
Integration Tests 16767/34768 48.2% 20.8%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant