fix(moe): forward permute fusion to HybridEP - #3618
Draft
HuiyingLi wants to merge 1 commit into
Draft
Conversation
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Forward the existing
moe_permute_fusionsetting through AutoModel's HybridEPdispatch/combine autograd wrappers to DeepEP's
fuse_permute_dispatchandfuse_unpermute_combineflags.Without this propagation, enabling
moe_permute_fusionchanges the localpermute/unpermute path but silently leaves the HybridEP DeepEP path unfused.
Changelog
permute_fusionfrom_HybridEPManagerinto HybridEP dispatch andcombine.
fusion flag in backward.
and for manager-level knob propagation.
Before your PR is "Ready for review"
Pre checks:
Validation
ruff format --checkon all four changed files: passed.ruff checkon the changed source files: passed.pytest -q tests/unit_tests/moe/test_fused_a2a.py tests/unit_tests/moe/test_token_dispatcher.py: 13 passed.421443037f64e9d422814bec9341c0559749c215:6936.18 (+5.89%).
7904.66 (+6.06%); all 40/40 steps completed with finite loss and gradient
norm.
Additional Information
Current
main(bb0fe53a) still omits this propagation and pins the sameDeepEP revision used for the H100 qualification. The relevant HybridEP code
path has no behavioral change between the qualification baseline and current
main.