fix(retrieval): support Sentence Transformers v6 metadata - #3600
Open
oliverholworthy wants to merge 3 commits into
Open
fix(retrieval): support Sentence Transformers v6 metadata#3600oliverholworthy wants to merge 3 commits into
oliverholworthy wants to merge 3 commits into
Conversation
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
/ok to test a975dae |
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3546.
Compatibility rationale
Sentence Transformers v6 moved Normalize to sentence_transformers.base.modules. The v6 release explicitly keeps existing models loadable, while checkpoints saved with the new path do not load on older releases. Keeping the older path for exports and accepting both paths on import therefore provides the widest compatibility.
Release notes: https://github.com/huggingface/sentence-transformers/releases/tag/v6.0.0
Migration guide: https://www.sbert.net/docs/migration_guide.html
Testing