Give collaborative layer markers their own map pane - #392
Merged
Conversation
Collab markers previously fell into Leaflet's default markerPane (fixed z-index 600), so they weren't part of the layer-order drawer and could render inconsistently relative to Incident/Asset markers depending on the user's pane order config. Adds a pane-collab pane, defaulted to sit under Incident markers but above Asset markers, and makes it a first-class entry in the draggable layer order list. Existing saved pane orders get the new pane inserted at its default relative position instead of always appended at the bottom. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
markerPane(fixed z-index 600) instead of one of the app's custom panes, so they weren't part of the "Marker Layer Order" drawer and could stack unpredictably relative to Incident/Asset markers.pane-collabpane, defaulted between Incident markers (above) and Asset markers (below), and wires collab markers to use it.paneDefs(like this one) is inserted at its default relative position in existing users' saved layer-order configs, rather than always landing at the bottom.Test plan
pane-collab), confirm it gets inserted in the correct default slot rather than at the bottom.🤖 Generated with Claude Code