Skip to content

🎨 Palette: Enhance accessibility and keyboard navigation in MacroListView - #145

Open
NSEvent wants to merge 3 commits into
mainfrom
palette/macro-list-button-a11y-11203710982324997227
Open

🎨 Palette: Enhance accessibility and keyboard navigation in MacroListView#145
NSEvent wants to merge 3 commits into
mainfrom
palette/macro-list-button-a11y-11203710982324997227

Conversation

@NSEvent

@NSEvent NSEvent commented Aug 18, 2026

Copy link
Copy Markdown
Owner

Replaced .onTapGesture on the macro list row's HStack with a proper semantic Button wrapper. This ensures the macro rows remain accessible to screen readers, naturally support focus state indicators for keyboard navigation, and can be activated via standard UI actions (like the spacebar).
Additionally, .contentShape(Rectangle()) was preserved inside the button's layout to maintain the expected clickable footprint, preventing UX regressions for mouse users.

Also updated Palette's journal mapping out these structural requirements for interactive elements in SwiftUI.


PR created automatically by Jules for task 11203710982324997227 started by @NSEvent

…View

Replaced `.onTapGesture` on the macro list row's HStack with a proper semantic `Button` wrapper. This ensures the macro rows remain accessible to screen readers, naturally support focus state indicators for keyboard navigation, and can be activated via standard UI actions (like the spacebar).
Additionally, `.contentShape(Rectangle())` was preserved inside the button's layout to maintain the expected clickable footprint, preventing UX regressions for mouse users.

Also updated Palette's journal mapping out these structural requirements for interactive elements in SwiftUI.

Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@NSEvent, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 17 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 85a2188a-dcd5-45fa-9227-f8d4b1814e1f

📥 Commits

Reviewing files that changed from the base of the PR and between 491237a and 0e3f546.

📒 Files selected for processing (4)
  • .Jules/palette.md
  • XboxControllerMapper/XboxControllerMapper/Views/Macros/MacroListView.swift
  • XboxControllerMapper/XboxControllerMapperTests/JoystickAndMouseMappingTests.swift
  • XboxControllerMapper/XboxControllerMapperTests/JoystickCustomDirectionMappingTests.swift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

google-labs-jules Bot and others added 2 commits August 18, 2026 09:25
Replaced `.onTapGesture` on the macro list row's HStack with a proper semantic `Button` wrapper for screen reader and keyboard accessibility.

Fixed failing tests in `JoystickCustomDirectionMappingTests` (force unwrapping nil optionals) and `JoystickAndMouseMappingTests` (flaky timing assumption in smooth scroll count).

Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
Replaced `.onTapGesture` on the macro list row's HStack with a proper semantic `Button` wrapper for screen reader and keyboard accessibility.

Fixed failing tests in `JoystickCustomDirectionMappingTests` (force unwrapping nil optionals) and `JoystickAndMouseMappingTests` (flaky timing assumption in smooth scroll count).

Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant