Skip to content

CONFIG: Fix FluentAssertions dependabot ignore to update-types syntax - #40

Merged
cjdutoit merged 1 commit into
mainfrom
users/perirrs/fa-ignore-fix
Aug 13, 2026
Merged

CONFIG: Fix FluentAssertions dependabot ignore to update-types syntax#40
cjdutoit merged 1 commit into
mainfrom
users/perirrs/fa-ignore-fix

Conversation

@perirrs

@perirrs perirrs commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

One-line baseline fix: the versions-list ignore form ('8.x','9.x','10.x','*') does not block nuget bumps - dependabot still raised FluentAssertions 8.10.0 PRs (closed with Christo's OK; 8.x is a paid license). Switched to update-types: version-update:semver-major, the form verified working across the nine uplifted repos. The [7.2.2] bracket pin in the csprojs remains the primary lock.

closes AB#30043

… (the versions-list form proved ineffective - dependabot still raised FA 8.10.0 PRs; see closed Notifications PR 48)
Copilot AI lite review requested due to automatic review settings August 12, 2026 22:16
@github-actions github-actions Bot added the CONFIG The configuration category is for any configuration changes i.e. setting up appsettings.json label Aug 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s Dependabot configuration to stop major-version updates for the FluentAssertions NuGet dependency using the update-types ignore syntax, aligning with the intended licensing/upgrade constraints while still allowing non-major updates where applicable.

Changes:

  • Replaced the versions: ["8.x", "9.x", "10.x", "*"] ignore rule for FluentAssertions with update-types: ["version-update:semver-major"].
  • Keeps Dependabot active for other dependency updates while preventing major-version bumps for FluentAssertions.
Suppressed comments (1)

.github/dependabot.yml:19

  • The ignore list indentation is inconsistent with the rest of the file (e.g., labels) and the file currently ends with a whitespace-only line. Reindenting the ignore entry and removing the trailing whitespace improves readability and avoids accidental YAML formatting issues.
    ignore:
        - dependency-name: "FluentAssertions"
          update-types: ["version-update:semver-major"]


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@perirrs
perirrs requested a review from cjdutoit August 12, 2026 22:18
@cjdutoit
cjdutoit merged commit 1a1d219 into main Aug 13, 2026
17 checks passed
@cjdutoit
cjdutoit deleted the users/perirrs/fa-ignore-fix branch August 13, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CONFIG The configuration category is for any configuration changes i.e. setting up appsettings.json

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants