CONFIG: Fix FluentAssertions dependabot ignore to update-types syntax - #40
Merged
Conversation
… (the versions-list form proved ineffective - dependabot still raised FA 8.10.0 PRs; see closed Notifications PR 48)
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Dependabot configuration to stop major-version updates for the FluentAssertions NuGet dependency using the update-types ignore syntax, aligning with the intended licensing/upgrade constraints while still allowing non-major updates where applicable.
Changes:
- Replaced the
versions: ["8.x", "9.x", "10.x", "*"]ignore rule forFluentAssertionswithupdate-types: ["version-update:semver-major"]. - Keeps Dependabot active for other dependency updates while preventing major-version bumps for
FluentAssertions.
Suppressed comments (1)
.github/dependabot.yml:19
- The
ignorelist indentation is inconsistent with the rest of the file (e.g.,labels) and the file currently ends with a whitespace-only line. Reindenting the ignore entry and removing the trailing whitespace improves readability and avoids accidental YAML formatting issues.
ignore:
- dependency-name: "FluentAssertions"
update-types: ["version-update:semver-major"]
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line baseline fix: the versions-list ignore form ('8.x','9.x','10.x','*') does not block nuget bumps - dependabot still raised FluentAssertions 8.10.0 PRs (closed with Christo's OK; 8.x is a paid license). Switched to update-types: version-update:semver-major, the form verified working across the nine uplifted repos. The [7.2.2] bracket pin in the csprojs remains the primary lock.
closes AB#30043